ArgumentNullException when reading empty/null PLP strings with new async behavior - #3884
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a test case to verify that reading empty and null PLP (Partially Length-Prefixed) strings asynchronously does not throw an ArgumentNullException when using the new async behavior. The test is a regression test for issue #593, which originally reported severe performance problems when reading large binary data asynchronously.
Changes:
- Added a new async test
ReadEmptyAndNullPlpStringsAsyncWithNewBehaviorthat validates reading NULL and empty string values from VARCHAR(MAX), NVARCHAR(MAX), and TEXT columns - The test disables compatibility mode to use the new async behavior via the UseCompatibilityAsyncBehaviour switch
cheenamalhotra
added
the
Area\Tests
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@cheenamalhotra where should i see the PRs i request from copilot? |
|
@SimonCropp I doubt you can control Copilot in this repo - only in your own fork |
|
@ErikEJ so isnt that a bug in copilot, that it is offering to submit PRs that it can actually do? |
|
If you get a test that works quickly and reliably enough for CI use do you want me to include it in #3872 or do you want to include my change in this PR?, either is fine. |
…on-when-reading-empty/null-PLP-strings-with-new-async-behavior
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…on-when-reading-empty/null-PLP-strings-with-new-async-behavior
1. Table name bracket-quoting: All three SQL statements (CREATE TABLE, INSERT INTO, SELECT FROM) now use [{tableName}]
instead of {tableName}, consistent with the rest of the file.
2. Comment accuracy: Updated the comment from "PLP string columns" to "large string columns (VARCHAR(MAX),
NVARCHAR(MAX) are PLP types; TEXT is a deprecated LOB type)" to accurately reflect that TEXT is not a PLP type.
attempt to replicate #593 (comment)