remove duplicate dictionary lookups

[SimonCropp]

No description provided.

[Copilot]

Pull request overview

Refactors several internal dictionary access patterns to avoid redundant ContainsKey + indexer lookups, primarily by switching to TryGetValue (and, for the DNS cache, direct indexer assignment) while preserving existing behavior in SqlDependency-related infrastructure.

Changes:

• Replace double-lookups with TryGetValue in SqlDependency* code paths.
• Simplify DNS cache insertion to a single overwrite assignment.
• Update server enumerator parsing to use TryGetValue for instance detail extraction.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependencyUtils.cs	Uses TryGetValue for dependency ID lookup under lock.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependencyListener.cs	Replaces repeated dictionary lookups with TryGetValue in app-domain/container tracking paths.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependency.cs	Uses TryGetValue to avoid multiple lookups in server/user hash management and default options composition.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SQLFallbackDNSCache.cs	Simplifies add/replace semantics to a single assignment into the ConcurrentDictionary.
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumeratorManagedHelper.netcore.cs	Uses TryGetValue when populating DataRow fields from parsed instance details.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

A glorious set of changes! 🚀 Just a couple of comments.

[mdaigle]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[codecov]

Codecov Report

❌ Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.49%. Comparing base (3303d80) to head (c9900e2).
⚠️ Report is 42 commits behind head on main.

Files with missing lines	Patch %	Lines
...ql/SqlDataSourceEnumeratorManagedHelper.netcore.cs	0.00%	8 Missing ⚠️
.../Microsoft/Data/SqlClient/SqlDependencyListener.cs	77.77%	2 Missing ⚠️
...src/Microsoft/Data/SqlClient/SqlDependencyUtils.cs	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3303d80) and HEAD (c9900e2). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (3303d80)	HEAD (c9900e2)
CI-SqlClient	2	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4000      +/-   ##
==========================================
- Coverage   74.38%   65.49%   -8.90%     
==========================================
  Files         287      275      -12     
  Lines       43982    65805   +21823     
==========================================
+ Hits        32717    43097   +10380     
- Misses      11265    22708   +11443     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	65.49% <47.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.