Skip to content

optimizers maximize #1300

New issue
New issue
Closed
Closed
optimizers maximize#1300

Description

@yueyinqiu
yueyinqiu
opened on Apr 26, 2024

Found during #1299.

When maximize is true and grad is false, this (in some optimizers' step method) will definitely throw an exception:

image

For instance:

image

I will try to fix this after #1299 has been merged.

Activity

  1. NiklasGustafsson commented on Apr 26, 2024

    @NiklasGustafsson
    NiklasGustafsson
    on Apr 26, 2024

    It's technically a different problem, but I would suggest lumping it in with #1299.

  2. yueyinqiu commented on May 9, 2024

    @yueyinqiu
    yueyinqiu
    on May 9, 2024
    ContributorAuthor

    fixed in #1299

  3. yueyinqiu
    closed this as completedon May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions