Skip to content

[.NET 8] perf regression in <LinkAssembliesNoShrink/> #7684

Closed
#7686
Closed
[.NET 8] perf regression in <LinkAssembliesNoShrink/>#7684
#7686
Assignees
dellis1972jonathanpeppers
Labels
Area: App+Library BuildIssues when building Library projects or Application projects.
Milestone
.NET 8

Description

@jonathanpeppers
jonathanpeppers
opened on Jan 10, 2023

Android application type

Android for .NET (net6.0-android, etc.)

Affected platform version

.NET 8 / main

Description

In .NET 7, in an old log I see:

image

This was an example of a .xaml change in a dotnet new maui project.

Now I see:

image

dotnet trace shows most of the time is:

image

So I think we might need to rework parts of dc3ccf2, maybe it can skip some things on incremental builds?

Less log messages would also help:

image

Steps to Reproduce

  1. dotnet new maui
  2. build
  3. change .xaml
  4. build again

Did you find any workaround?

Set $(AndroidUseDesignerAssembly) to false, would skip some of these steps.

Relevant log output

msbuild.zip

Activity

  1. jonathanpeppers
    added
    Area: App+Library BuildIssues when building Library projects or Application projects.
    on Jan 10, 2023
  2. jonathanpeppers
    added this to the .NET 8 milestone on Jan 10, 2023
  3. jonathanpeppers
    assigned
    dellis1972
    and
    jonathanpeppers
    on Jan 10, 2023
  4. ghost added
    needs-triageIssues that need to be assigned.
    on Jan 10, 2023
  5. jonathanpeppers
    moved this to Todo in .NET 8 MAUI Performance, App Size, Inner Loopon Jan 10, 2023
  6. jonathanpeppers
    added this to .NET 8 MAUI Performance, App Size, Inner Loopon Jan 10, 2023

  7. dellis1972 commented on Jan 10, 2023

    @dellis1972
    dellis1972
    on Jan 10, 2023
    Contributor

    This step is converting old Resource.designer.cs code over to the new system. So once Maui has switched over to using the newer system it should be better as it will have less work to do.

  8. dellis1972
    removed
    needs-triageIssues that need to be assigned.
    on Jan 10, 2023

  9. jonathanpeppers commented on Jan 11, 2023

    @jonathanpeppers
    jonathanpeppers
    on Jan 11, 2023
    MemberAuthor

    Yeah, we can keep an eye and test again when we have a new MAUI.

    What made me think something else is going on, is this target builds partially:

    Target Name=_LinkAssembliesNoShrink Project=bar.csproj
Building target "_LinkAssembliesNoShrink" partially, because some output files are out of date with respect to their input files.
[ResolvedAssemblies: Input=obj\Debug\net8.0-android\android-arm64\bar.dll, Output=obj\Debug\net8.0-android\android-arm64\android\assets\bar.dll] Input file is newer than output file.

    So in theory it should only be looking at bar.dll in this example?

  10. dellis1972 commented on Jan 11, 2023

    @dellis1972
    dellis1972
    on Jan 11, 2023
    Contributor

    It is buiding partially. but the Task in the target is not using any of the "partial" calculated ItemGroups

    <LinkAssembliesNoShrink
      ResolvedAssemblies="@(_AllResolvedAssemblies)"
      SourceFiles="@(ResolvedAssemblies)"
      DestinationFiles="@(ResolvedAssemblies->'$(MonoAndroidIntermediateAssemblyDir)%(DestinationSubPath)')"
      TargetName="$(TargetName)"
      AddKeepAlives="$(AndroidAddKeepAlives)"
      UseDesignerAssembly="$(AndroidUseDesignerAssembly)"
      Deterministic="$(Deterministic)"
      UsingAndroidNETSdk="$(UsingAndroidNETSdk)"
  />

    Its using @(_AllResolvedAssemblies) , so all the items will be processed.

  11. jonathanpeppers commented on Jan 11, 2023

    @jonathanpeppers
    jonathanpeppers
    on Jan 11, 2023
    MemberAuthor

    Previously @(_AllResolvedAssemblies) was only used for search paths on the DirectoryAssemblyResolver -- it's possible Mono.Cecil would need to go load other assemblies.

    The "partial" part is:

      SourceFiles="@(ResolvedAssemblies)"
  DestinationFiles="@(ResolvedAssemblies->'$(MonoAndroidIntermediateAssemblyDir)%(DestinationSubPath)')"
  12. jonathanpeppers
    added a commit that references this issue on Jan 11, 2023

    [Xamarin.Android.Build.Tasks] lazily populate Resource lookup

    30501c1

  13. jonathanpeppers commented on Jan 11, 2023

    @jonathanpeppers
    jonathanpeppers
    on Jan 11, 2023
    MemberAuthor

    If I'm reading the code right, I think this will fix this: #7686

    But let's see if anything breaks?

  14. jonathanpeppers
    added a commit that references this issue on Jan 12, 2023

    [Xamarin.Android.Build.Tasks] lazily populate Resource lookup

    6e09a65
  15. dellis1972
    closed this as completedin #7686on Jan 17, 2023
  16. dellis1972
    added a commit that references this issue on Jan 17, 2023

    [Xamarin.Android.Build.Tasks] lazily populate Resource lookup (#7686)

    899d781
  17. github-project-automation
    moved this from Todo to Done in .NET 8 MAUI Performance, App Size, Inner Loopon Jan 17, 2023
  18. ghost locked as resolved and limited conversation to collaborators on Feb 17, 2023
  19. jonathanpeppers
    moved this from Done to Blogged in .NET 8 MAUI Performance, App Size, Inner Loopon Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: App+Library BuildIssues when building Library projects or Application projects.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions