Skip to content

[main] Update dependencies from dotnet/sdk#10008

Merged
jonathanpeppers merged 4 commits into
mainfrom
darc-main-65206aeb-3261-4826-abf5-364b0058c217
Apr 15, 2025
Merged

[main] Update dependencies from dotnet/sdk#10008
jonathanpeppers merged 4 commits into
mainfrom
darc-main-65206aeb-3261-4826-abf5-364b0058c217

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NETCore.App.Ref: from 10.0.0-preview.4.25178.6 to 10.0.0-preview.4.25210.5 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-preview.4.25176.1 to 10.0.0-preview.4.25176.1 (parent: Microsoft.NETCore.App.Ref)
    • Microsoft.NET.ILLink.Tasks: from 10.0.0-preview.4.25178.6 to 10.0.0-preview.4.25210.5 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

Microsoft.NET.Sdk
 From Version 10.0.100-preview.4.25180.3 -> To Version 10.0.100-preview.4.25206.7

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.NET.ILLink.Tasks
 From Version 10.0.0-preview.4.25178.6 -> To Version 10.0.0-preview.4.25174.9 (parent: Microsoft.NET.Sdk
Comment thread eng/Version.Details.xml Outdated
dotnet-maestro Bot and others added 2 commits April 14, 2025 05:01
Microsoft.NET.Sdk
 From Version 10.0.100-preview.4.25180.3 -> To Version 10.0.100-preview.4.25211.22

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.NET.ILLink.Tasks
 From Version 10.0.0-preview.4.25178.6 -> To Version 10.0.0-preview.4.25210.5 (parent: Microsoft.NET.Sdk
@pjcollins
pjcollins self-requested a review April 14, 2025 15:02
@pjcollins

Copy link
Copy Markdown
Member

Looks like we have an apk size discrepency that will require some apkdesc baseline updates now, this seems marginal enough to be acceptable:

Error: apkdiff: File 'lib/arm64-v8a/lib_System.Diagnostics.DiagnosticSource.dll.so' has changed by 3,928 bytes (12.13 %). This exceeds the threshold of 5.00 %.

@jonathanpeppers jonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size regression only happened on the Xamarin.Forms sample, looks like dotnet new android still passes.

I just updated the file, which is what I normally do. Will merge if this ends up green after.

Comment thread NuGet.config
Comment on lines +7 to +8
<add key="darc-pub-dotnet-android-e7876a4" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-e7876a4f/nuget/v3/index.json" />
<add key="darc-pub-dotnet-android-82d8938" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-82d8938c/nuget/v3/index.json" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maestro must have removed because they are on NuGet.org now?

It's fine to restore them, but probably doesn't matter either way.

@jonathanpeppers
jonathanpeppers merged commit 3c1a9b1 into main Apr 15, 2025
@jonathanpeppers
jonathanpeppers deleted the darc-main-65206aeb-3261-4826-abf5-364b0058c217 branch April 15, 2025 17:52
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants