Skip to content

Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.4 to 4.14.0#11562

Merged
jonathanpeppers merged 1 commit into
release/10.0.1xxfrom
dependabot/nuget/build-tools/banned-apis/release/10.0.1xx/Microsoft.CodeAnalysis.BannedApiAnalyzers-4.14.0
Jun 3, 2026
Merged

Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.4 to 4.14.0#11562
jonathanpeppers merged 1 commit into
release/10.0.1xxfrom
dependabot/nuget/build-tools/banned-apis/release/10.0.1xx/Microsoft.CodeAnalysis.BannedApiAnalyzers-4.14.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 2, 2026

Copy link
Copy Markdown
Contributor

Updated Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.4 to 4.14.0.

Release notes

Sourced from Microsoft.CodeAnalysis.BannedApiAnalyzers's releases.

4.2.0-4.22266.5

Release

4.2.0-3.22151.16

Release

4.2.0-1.22108.11

Release

4.0.0-2.21354.7

Release

4.0.0-2.21254.26

Release

4.0.0-1.21277.15

Release

3.10.0-3.21201.20

Release

3.10.0-2.21153.36

Release

3.10.0-1.21102.26

Release

3.7.0-3.20312.3

Release Notes
Install Instructions

Repos

3.7.0-3.20269.11

Release Notes
Install Instructions

Repos

3.7.0-2.20277.1

Release Notes
Install Instructions

Repos

3.6.0

Release Notes
Install Instructions

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: Microsoft.CodeAnalysis.BannedApiAnalyzers
  dependency-version: 4.14.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file. labels Jun 2, 2026
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file. .NET Pull requests that update .NET code labels Jun 2, 2026
@jonathanpeppers jonathanpeppers merged commit 929c149 into release/10.0.1xx Jun 3, 2026
1 of 2 checks passed
@jonathanpeppers jonathanpeppers deleted the dependabot/nuget/build-tools/banned-apis/release/10.0.1xx/Microsoft.CodeAnalysis.BannedApiAnalyzers-4.14.0 branch June 3, 2026 01:15
jonathanpeppers pushed a commit to jonathanpeppers/xamarin-android that referenced this pull request Jun 3, 2026
…otnet#11562)

---
updated-dependencies:
- dependency-name: Microsoft.CodeAnalysis.BannedApiAnalyzers
  dependency-version: 4.14.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
simonrozsival added a commit that referenced this pull request Jun 3, 2026
The dependabot bump (#11562) committed banned-apis.targets with CRLF bytes
stored directly in the git blob. Since .gitattributes declares
`*.targets eol=crlf`, the blob must be stored normalized (LF) and only
converted to CRLF on checkout. The un-normalized blob caused the CI
'Ensure no modified/untracked files' check to fail because git's
renormalization detection flagged the file as modified.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jonathanpeppers added a commit that referenced this pull request Jun 8, 2026
….400 SDK (#11579)

PRs targeting `release/10.0.1xx` were failing in two CI steps after PR #11550 bumped the SDK to `10.0.400-preview.0.26281.104`. This PR fixes both.

## 1. `ConfigureLocalWorkload` target

**Symptom** (example failing builds: [14272822](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=14272822&view=logs&j=67c36b7f-840a-5272-a1e2-d24133c10cf7&t=67453bd5-dba0-530a-0c1e-8cde57517c28&l=299), [14286661](https://devdiv.visualstudio.com/DevDiv/DevDiv%20Team/_build/results?buildId=14286661&view=logs&j=cac0e8d3-0ef5-5d2b-b57e-e8fde7204df3&t=1613c12f-4a8c-569b-7239-df554c009fc1&l=300)):

```
Workload installation failed: Workload ID android-deps is not recognized.
```

**Root cause:** `SdkDirectoryWorkloadManifestProvider` discovers loose manifests under `<root>/<SdkFeatureBand.ToString()>/`. For SDK `10.0.400-preview.0.26281.104` that string is `10.0.400-preview.0`, not `10.0.400`. The synthetic `android-deps` workload manifest was being written to `bin/Release/lib/sdk-manifests/10.0.400/android.deps.workload/...`, so the SDK's resolver never found it. Previous stable / `-rtm` / `-dev` SDKs returned just `10.0.400` from `SdkFeatureBand.ToString()`, which is why this worked before #11550.

**Fix in `build-tools/create-packs/ConfigureLocalWorkload.targets`:**

- Place the synthetic `android.deps.workload` folder under `$(DotNetPreviewVersionBand)` (e.g. `10.0.400-preview.0`) instead of `$(DotNetSdkManifestsFolder)` (`10.0.400`). `DotNetPreviewVersionBand` already matches `SdkFeatureBand.ToString()` for both stable and preview SDKs.
- Also (defensive): run `dotnet workload config --update-mode manifests` before the install to ensure the local SDK is in loose-manifest mode, since workload-set mode is now the default in 10.0.400.

`_LocalAndroidManifestFolder` is intentionally left under `$(DotNetSdkManifestsFolder)` — it is only the packaging source for the workload-manifest NuGet, not a path the SDK reads at install time.

## 2. "Ensure no modified/untracked files" dirty-tree check

**Symptom** (example failing build: [14283875](https://devdiv.visualstudio.com/DevDiv/DevDiv%20Team/_build/results?buildId=14283875&view=logs&j=96fd57f5-f69e-53c7-3d47-f67e6cf9b93e&t=81b9bc1a-74a9-50ea-e57c-169f5aa3474c&l=16)): the dirty-tree check reported `build-tools/banned-apis/banned-apis.targets` and `src/Mono.Android/Mono.Android.csproj` as modified.

**Root cause:** dependabot bumps (#11562, #11563) stored these files with CRLF directly in the git index. `.gitattributes` declares `*.targets` and `*.csproj` as `eol=crlf`, which means the index should hold LF and the smudge filter writes CRLF to the working tree on checkout. When CRLF is stored in the index, any cross-platform tool that touches the file causes `git status` to report changes.

**Fix:** ran `git add --renormalize` on just those two files. The diff is whitespace-only (verifiable with `git diff -w`); content is unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant