Rework Design Time Build to use .aar files directly. - #9423
Closed
dellis1972 wants to merge 21 commits into
Closed
Conversation
dellis1972
force-pushed
the
dtbrework
branch
2 times, most recently
from
October 24, 2024 14:20
d08fdf2 to
8f05381
Compare
dellis1972
force-pushed
the
dtbrework
branch
from
November 12, 2024 09:09
373a6a5 to
f96ca96
Compare
dellis1972
force-pushed
the
dtbrework
branch
3 times, most recently
from
December 5, 2024 13:35
8b86bf8 to
ddc632f
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dellis1972
marked this pull request as ready for review
December 9, 2024 19:46
dellis1972
requested review from
grendello,
jonathanpeppers and
jonpryor
as code owners
December 9, 2024 19:46
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Moving to #9700 |
jonpryor
reviewed
Jan 22, 2025
| per TargetFramework. | ||
| --> | ||
| <_DesignerIntermediateOutputPath Condition=" '$(_DesignerIntermediateOutputPath)' == '' And '$(_OuterIntermediateOutputPath)' != '' ">$(_OuterIntermediateOutputPath)</_DesignerIntermediateOutputPath> | ||
| <_DesignerIntermediateOutputPath Condition=" '$(_DesignerIntermediateOutputPath)' == '' And '$(_OuterIntermediateOutputPath)' != '' And '$(AndroidUseDesignerAssembly)' == 'True' And '$(DesignTimeBuild)' == 'true' ">$(_OuterIntermediateOutputPath)designtime\</_DesignerIntermediateOutputPath> |
Contributor
There was a problem hiding this comment.
Doesn't this line need to come before line 47? Otherwise, this line will never execute, because line 47 will set $(_DesignerIntermediateOutputPath) first, preventing this line from executing.
Contributor
Author
There was a problem hiding this comment.
I'll double check. Can we move the review to #9700 as it has all the tests running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context dotnet/maui#25207
Also
designtimefolder.