[release/9.0] Fix OneLoc GitHub App installation selection - #17314
Merged
missymessa merged 1 commit intoAug 11, 2026
Merged
missymessa merged 1 commit into
missymessa merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12710df-91d5-49e4-b327-337932478b0b
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports a fix to eng/common/Get-GitHubAppToken.ps1 on release/9.0 to correctly select the intended GitHub App installation when multiple installations exist, avoiding minting a token for the wrong owner (notably preventing dotnet builds from accidentally using the microsoft installation).
Changes:
- Avoid nested-array behavior from
Invoke-RestMethodby assigning the response before wrapping it, ensuring installations are enumerated correctly across pages. - Require exactly one installation matching
InstallationOwner(fail fast on 0 or >1 matches instead of silently taking the first). - Log the selected installation owner and installation ID for diagnosability.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
missymessa
enabled auto-merge (squash)
August 11, 2026 14:18
mmitche
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #17312 to
release/9.0.OneLoc GitHub App authentication is enabled by default on this branch. This fix flattens the installations response, requires exactly one owner match, and prevents dotnet builds from receiving the Microsoft installation token.
Validation:
git diff --checkpassesTracking: https://dev.azure.com/dnceng/internal/_workitems/edit/11966