API diff between .NET 9 Preview 7 and .NET 9 RC 1 - #9497
Merged
Merged
Conversation
adamsitnik
approved these changes
Sep 11, 2024
adamsitnik
left a comment
adamsitnik
left a comment
Member
There was a problem hiding this comment.
System.Reflection.Metadata LGTM, thank you @carlossanlop !
eiriktsarpalis
approved these changes
Sep 11, 2024
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
Member
There was a problem hiding this comment.
System.Collections LGTM
eiriktsarpalis
self-requested a review
September 11, 2024 12:32
stephentoub
approved these changes
Sep 11, 2024
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
Member
There was a problem hiding this comment.
Shouldn't this also include the JsonElement.GetPropertyCount that was retroactively added to RC1 via dotnet/runtime#106576?
Contributor
Author
@eiriktsarpalis That backport dotnet/runtime#106576 was merged into release/9.0 which from the start was pointing to RC2. I don't see any RC1 backport PRs (release/9.0-rc1) unfortunately. |
Member
Ah good, before going OOF I was under the impression it would be merged for RC1 but I guess we missed the deadline. |
buyaa-n
reviewed
Sep 11, 2024
Comment on lines
+5
to
+31
| + public sealed class BrotliCompressionOptions { | ||
| + public BrotliCompressionOptions(); | ||
| + public int Quality { get; set; } | ||
| + } | ||
| public sealed class BrotliStream : Stream { | ||
| + public BrotliStream(Stream stream, BrotliCompressionOptions compressionOptions, bool leaveOpen = false); | ||
| } | ||
| public class DeflateStream : Stream { | ||
| + public DeflateStream(Stream stream, ZLibCompressionOptions compressionOptions, bool leaveOpen = false); | ||
| } | ||
| public class GZipStream : Stream { | ||
| + public GZipStream(Stream stream, ZLibCompressionOptions compressionOptions, bool leaveOpen = false); | ||
| } | ||
| + public sealed class ZLibCompressionOptions { | ||
| + public ZLibCompressionOptions(); | ||
| + public int CompressionLevel { get; set; } | ||
| + public ZLibCompressionStrategy CompressionStrategy { get; set; } | ||
| + } | ||
| + public enum ZLibCompressionStrategy { | ||
| + Default = 0, | ||
| + Filtered = 1, | ||
| + Fixed = 4, | ||
| + HuffmanOnly = 2, | ||
| + RunLengthEncoding = 3, | ||
| + } | ||
| public sealed class ZLibStream : Stream { | ||
| + public ZLibStream(Stream stream, ZLibCompressionOptions compressionOptions, bool leaveOpen = false); |
Contributor
There was a problem hiding this comment.
System.IO.Compression part LGTM
buyaa-n
reviewed
Sep 11, 2024
Comment on lines
+6
to
+15
| - public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type returnType, Type[]? parameterTypes); | ||
| + public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type? returnType, Type[]? parameterTypes); | ||
| - public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers); | ||
| + public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type? returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers); | ||
| - public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type returnType, Type[]? parameterTypes); | ||
| + public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type? returnType, Type[]? parameterTypes); | ||
| - public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers); | ||
| + public PropertyBuilder DefineProperty(string name, PropertyAttributes attributes, Type? returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers); | ||
| - protected abstract PropertyBuilder DefinePropertyCore(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers); | ||
| + protected abstract PropertyBuilder DefinePropertyCore(string name, PropertyAttributes attributes, CallingConventions callingConvention, Type? returnType, Type[]? returnTypeRequiredCustomModifiers, Type[]? returnTypeOptionalCustomModifiers, Type[]? parameterTypes, Type[][]? parameterTypeRequiredCustomModifiers, Type[][]? parameterTypeOptionalCustomModifiers); |
Contributor
There was a problem hiding this comment.
LGTM, note that these are just a nullability change for one parameter Type returnType => Type? returnType
| @@ -0,0 +1,179 @@ | |||
| # System.Runtime.Intrinsics.Arm | |||
Member
There was a problem hiding this comment.
System.Runtime.Intrinsics.Arm LGTM
CC. @dotnet/area-system-runtime-intrinsics, @dotnet/arm64-contrib
| @@ -0,0 +1,41 @@ | |||
| # System.Runtime.Intrinsics.X86 | |||
Member
There was a problem hiding this comment.
System.Runtime.Intrinsics.X86 LGTM
CC. @dotnet/area-system-runtime-intrinsics
tannergooding
approved these changes
Sep 11, 2024
Member
|
System.Security.* LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo area owners:
Libraries area owners:
Known api-diff tool issues:
If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:
{or{}arcade#10981([AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API arcade#13814)protected internalvisibility should stop showing. AsmDiff: Do not show APIs withprotected internalvisibility arcade#14579