This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Reenable the MVID tests on ILC as we support that now. - #20644
Merged
1 commit merged intoJun 2, 2017
Merged
1 commit merged into
1 commit merged into
Conversation
This required adding a dummy type to TinyAssembly.dll (and hand-patching in the original mvid) as ILC can't be forced to keep an empty assembly in the image.
Member
|
Other than my standard complaint about checking in binaries, looks fine. |
Author
|
Not much choice on this one - the test tests for a specific Guid. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required adding a dummy type to TinyAssembly.dll
(and hand-patching in the original mvid) as ILC
can't be forced to keep an empty assembly in the image.