This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Convert UTF-16 encoded files into UTF8 - #2346
Merged
Merged
Conversation
UTF16 encoded files trip up both Git and GitHub since the huristic they use to determine if a file is binary or not depends on the existence of null bytes in a file, which is common in UTF-16 encoded source. This converts all the UTF-16 encoded files into UTF-8 with an explicit byte order marker.
Contributor
Author
|
The GitHub provided diff here is pretty terrible, since it believes the source files are binary. I had success locally using kdiff3 + git difftool -d. It shows the files and for each one tells me they are text equal but not binary equal. |
Member
|
Thanks. The only other differences I saw were adding some newlines at the end of files. LGTM. |
Member
|
I assume this supersedes #1470? |
Contributor
Author
|
Maybe? It was unclear if we landed on a BOM vs no BOM call, but this certainly gets us closer. |
ellismg
added a commit
that referenced
this pull request
Jul 13, 2015
Convert UTF-16 encoded files into UTF8
Member
|
Yep, thanks, I actually didn't care about BOM vs no BOM when I opened https://github.com/dotnet/corefx/issues/1339, so this is fine by me 👍 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Convert UTF-16 encoded files into UTF8 Commit migrated from dotnet/corefx@617c87a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF16 encoded files trip up both Git and GitHub since the huristic they
use to determine if a file is binary or not depends on the existence of
null bytes in a file, which is common in UTF-16 encoded source.
This converts all the UTF-16 encoded files into UTF-8 with an explicit
byte order marker.