This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Repository navigation
ColumnName indexer on DataFrame - #2959
Merged
Merged
Conversation
gfoidl
reviewed
Aug 31, 2020
| /// <exception cref="ArgumentException">Throws if <paramref name="columnName"/> is not present in this <see cref="DataFrame"/></exception> | ||
| public DataFrameColumn this[string columnName] | ||
| { | ||
| get => Columns[columnName]; |
Member
There was a problem hiding this comment.
The case that the column doesn't exist is handled and tested.
What's about the case of columnName = null?
Author
There was a problem hiding this comment.
As it turns out, we have too many overloads of this indexer, so the only way to call this is to do df[(string)null]. I fixed the null case just in case though :)
eerhardt
approved these changes
Aug 31, 2020
eerhardt
left a comment
eerhardt
left a comment
Member
There was a problem hiding this comment.
Looks good, after adding an exception test for columnName = null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2934
This change brings back the column name indexer on
DataFrame. I modified a couple test cases to test the new getter and setter.cc @hamaze