Repository navigation
Keep official builds running after test failures - #6041
Merged
max-charlamb merged 2 commits intoSep 16, 2026
Merged
Conversation
Preserve per-platform build and test dependencies while making test jobs non-blocking only for official builds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79f15e34-e782-41ec-add6-8b3351cdc967
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Non-blocking behavior currently masks setup, artifact, and Helix submission failures; narrow it to test execution and result publication.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Keeps platform-specific tests running in parallel while allowing official builds to continue after test failures.
Changes:
- Moves test legs into the build stage with platform-specific dependencies.
- Adds official-build continuation behavior for regular and SOS Helix tests.
- Preserves artifact producer-consumer ordering.
File summaries
| File | Summary |
|---|---|
eng/pipelines/sos-helix.yml |
Adds official-build continuation behavior; setup and submission failures should remain blocking. |
eng/pipelines/build.yml |
Adds official-only error tolerance and per-platform dependencies; scope continuation to test execution and result publication. |
diagnostics.yml |
Reorganizes test legs and wires platform-specific dependencies. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Keep artifact download and job setup failures blocking while allowing only test execution failures to continue in official builds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 79f15e34-e782-41ec-add6-8b3351cdc967
Member
|
/ba-g osx timeout |
max-charlamb
approved these changes
Sep 16, 2026
This was referenced Sep 16, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve per-platform test parallelism and make test failures non-blocking only for official builds.