Repository navigation
Fix dumpgcdata test's pinned-object assumption - #6128
Merged
max-charlamb merged 4 commits intoOct 22, 2026
Merged
Conversation
Exercise per-heap GC statistics by checking that an explicitly induced compacting collection increases each heap's compaction-reason counter. The pre-and-post-pin statistic is not a pinned-object count and depended on a runtime-owned sentinel that moved to the frozen heap. Fixes dotnet/runtime#136190 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2c5c55e-f006-43a2-ace3-956b3a1b4121
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2c5c55e-f006-43a2-ace3-956b3a1b4121
rcj1
reviewed
Oct 22, 2026
added 2 commits
October 22, 2026 15:35
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2c5c55e-f006-43a2-ace3-956b3a1b4121
This reverts commit ad2646f. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2c5c55e-f006-43a2-ace3-956b3a1b4121
rcj1
approved these changes
Oct 22, 2026
max-charlamb
enabled auto-merge (squash)
October 22, 2026 20:35
Member
Author
|
/ba-g CI previously passed and blocks clean CI in runtime |
max-charlamb
disabled auto-merge
October 22, 2026 21:21
This was referenced Oct 22, 2026
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dotnet/runtime#136190.
The SOS test treated
dumpgcdata'spre and post pinstatistic as a pinned-object count. It actually records a GC pinned-plug bookkeeping condition. The expected value depended on a runtime-owned pinned sentinel, not the debuggee's pinned 1 MB array. Moving that sentinel to the frozen heap in dotnet/runtime#135326 exposed the faulty assumption; changing the expectation to zero would preserve the same problem.Replace this incidental oracle with a controlled GC operation:
induced compacting GCcounter increases from its observed baseline, without assuming an initial or final count.No runtime or cDAC implementation changes are needed.
Validation