Repository navigation
Annotation ingestion - #1373
Merged
Merged
Annotation ingestion#1373
Conversation
ghost
added
NikolaMilosavljevic
approved these changes
Jul 31, 2024
lbussell
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in #1367 for waiting for MAR ingestion of annotations is incorrect. The input to that command as it was defined is using the digests of the images to be annotated. It should be using the digests of the annotations that were created. This can be just a flat list of digests. There's no need for structured data here.
To do this, I've modified the
AnnotateEolDigestsCommandclass to output a file containing the list of annotation digests that were created. This is then fed to theWaitForMarAnnotationIngestionCommandso that it can query the correct digest values.