Repository navigation
Fix test stage matrix generation - #1465
Merged
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
MichaelSimons
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes from #1459 cause a failure during the Test stage (example build - internal link):
generateBuildMatrix: command not found.This is because it's attempting to run the command directly from the agent rather than from the container. This was a result of a mistake in the YAML. It was attempting to condition the logic differently depending on whether it was generating a matrix for the test stage or not. But that was unnecessary. In both build stage and test stage scenarios, it can use the same template logic for running the command.
Another issue was that
Set GenerateBuildMatrix Commandstep had a silent failure:commonMatrixAndBuildOptions: command not found. This is because the common init steps were not being passed to the generate-matrix.yml template for the test stage. That's been fixed as well.