Repository navigation
Pass storage account scope to GetToken in Build command - #1925
Merged
Merged
Conversation
mthalman
approved these changes
Jan 12, 2026
lbussell
enabled auto-merge (squash)
January 12, 2026 17:35
lbussell
added a commit
that referenced
this pull request
Jan 14, 2026
Follow up to #1925 (the context is in that PR's description).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During release staging, authentication to the staging storage account was failing.
This is because of the changes to token caching from #1879. Previously we needed to pass the token scope as an argument to the
GetCredential()method, since that method would create both the credential and the token in order to cache the token up front. But the scope is only needed to create the token. Since we no longer cache the token, we need to pass in the scope to the credential'sGetTokenmethod instead. The scope argument toGetCredential()is not used.This is a targeted fix to unblock release staging. A follow-up PR will contain a proper refactor to remove the unused argument from
TokenCredentialProvider.GetCredential.