Port over docs for System.Runtime.InteropServices#9132
Merged
jkoritzinsky merged 5 commits intoJul 11, 2023
Conversation
ghost
assigned
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Do we address all the missing comments described at dotnet/runtime#88573. |
Member
Author
I believe so, but I still am working through the validation. @carlossanlop what tool do you use to determine which APIs are missing documentation? I'd like to use it to validate that this PR covers all of the APIs in our area. |
gewarren
reviewed
Jul 11, 2023
gewarren
left a comment
gewarren
left a comment
Collaborator
There was a problem hiding this comment.
I'm about 3/4 of the way through so far (to IIUnknownStrategy.xml).
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
gewarren
reviewed
Jul 11, 2023
gewarren
left a comment
gewarren
left a comment
Collaborator
There was a problem hiding this comment.
Here's the rest of my suggestions.
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
Learn Build status updates of commit a6d7d34: 💡 Validation status: suggestions
This comment lists only the first 25 files in the pull request. xml/System.Runtime.InteropServices.Marshalling/ComObject.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port documentation from dotnet/runtime for System.Runtime.InteropServices.dll.
Depends on dotnet/runtime#88627
Contributes to dotnet/runtime#88561 (it might fix it, not sure what other docs are still missing after this PR).