Repository navigation
Refactor Update Dependencies project to facilitate adding additional commands - #6378
Merged
Merged
Conversation
1 task
mthalman
reviewed
Apr 17, 2025
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
mthalman
approved these changes
Apr 17, 2025
lbussell
enabled auto-merge (squash)
April 17, 2025 15:10
lbussell
disabled auto-merge
April 17, 2025 19:51
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
May 9, 2025
…commands (dotnet#6378) Co-authored-by: Matt Thalman <mthalman@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Set-DotNetVersions.ps1andGet-DropVersions.ps1to construct the correct set of arguments for update operations. It is desirable to use .NET for this instead.Details
update-dependencies specific 10.0 --product-version foo=bar ...update-dependencies from-channel 4567 https://github.com/dotnet/dotnetupdate-dependencies from-builds 123456update-dependencies from-builds 123456 133337 ...SpecificCommandand call it using arguments, or use any of the other existing classes to facilitate updating versions, e.g.DockerfileShaUpdater.CreateUpdaters(...) ...Other changes
System.CommandLine2.0.0 Beta 5System.CommandLine.NamingConventionBinderto bind options to propertiesFixes #3899... sorta.