Repository navigation
Refactor Linux Dockerfile templates to make changing shas easier - #6500
Merged
Merged
Conversation
lbussell
requested review from
a team,
benjaminpetit,
joperezr and
wiktork
as code owners
June 24, 2025 21:39
mthalman
reviewed
Jun 25, 2025
mthalman
approved these changes
Jun 25, 2025
lbussell
enabled auto-merge (squash)
June 26, 2025 15:16
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to refactor Dockerfile templates to make the following two tasks easier:
Summary:
download-dotnettemplate. So when we want to switch to online shas, we only need to change the arguments todownload-dotnet.There should be no functional changes here. There are a few minor stylistic changes:
curlcommand to download both extension binaries