Skip to content

Add option to download the checksum file in Dockerfile.linux.download-appliance - #6577

Merged
benjaminpetit merged 8 commits into
dotnet:nightlyfrom
benjaminpetit:yarp-shafile
Jul 25, 2025
Merged

benjaminpetit merged 8 commits into
dotnet:nightlyfrom
benjaminpetit:yarp-shafile

Conversation

@benjaminpetit

Copy link
Copy Markdown
Contributor

In this PR:

  • Add option to download the checksum file in Dockerfile.linux.download-appliance.
  • And migrate YARP to that method.

The template could be improved, I think.

Related issue: #6569

url, and use it to build the YARP Dockerfile
@benjaminpetit
benjaminpetit requested a review from a team as a code owner July 25, 2025 14:35
@benjaminpetit
benjaminpetit requested review from Copilot and removed request for a team July 25, 2025 14:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to download checksum files in the Dockerfile template system and migrates YARP to use this new method. The changes replace the hardcoded SHA512 checksums with dynamic checksum file downloads, enabling more flexible and maintainable checksum validation.

Key changes:

  • Enhanced the download appliance template to support downloading separate checksum files
  • Migrated YARP from ZIP to tar.gz format with dynamic checksum validation
  • Updated YARP version from 3.0.0-preview.1.25373.1 to 3.0.0-preview.1.25375.1

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
eng/dockerfile-templates/Dockerfile.linux.download-appliance Enhanced template to support downloading checksum files and conditional validation
eng/dockerfile-templates/yarp/Dockerfile.linux Updated YARP template to use tar.gz format and checksum URL download
src/yarp/2.3/azurelinux-distroless/amd64/Dockerfile Generated Dockerfile with new download method for amd64
src/yarp/2.3/azurelinux-distroless/arm64v8/Dockerfile Generated Dockerfile with new download method for arm64v8
manifest.versions.json Updated YARP version and added checksum base URLs
README.yarp.md Updated version tags in documentation

Comment thread manifest.versions.json Resolved
@benjaminpetit
benjaminpetit enabled auto-merge July 25, 2025 17:27
@lbussell
lbussell requested a review from mthalman July 25, 2025 17:33
@benjaminpetit
benjaminpetit merged commit 0b94303 into dotnet:nightly Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants