Skip to content

Retrying execution strategy in tests hides MARS requirement for split query #21427

Description

@roji

When working on the EFCore.PG preview6 release, I ran into something curious: all tests were passing although I did nothing to enforce buffering for split queries (as discussed in #21420). Long story short, it turns out that like for SQL Server, I have an NpgsqlDbContextOptionsBuilderExtensions which configures a retrying strategy for all tests. That strategy turns on buffering, which makes query splitting tests pass; but a user trying split queries would get failures because of MARS.

Our functional test suite should fail if query splitting isn't properly supported. Options:

  • Find out why we use a retrying strategy everywhere and consider removing it. This would make our tests run more similar to how many users use EF Core.
  • If we need to keep the strategy (e.g. because otherwise tests are flaky), we should at least add some testing without the strategy the would fail if the provider hasn't been properly implemented split queries.

Activity

  1. roji commented on Jun 29, 2020

    @roji
    MemberAuthor

    Triage decision: add a test doing split queries without a retrying strategy

  2. added this to the Backlog milestone on Jun 29, 2020
  3. ajcvickers commented on Jun 29, 2020

    @ajcvickers
    Contributor

    Backlog to discuss using execution strategies in tests.

  4. modified the milestones: Backlog, MQ on Sep 11, 2020
  5. added theissue type on Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions