[release/11.0] Allow EF.Parameter and EF.Constant on context properties in query filters

[Copilot]

Fixes #39081

Description
A validation was added for compiled queries and global query filters to detect unsupported constants. That incorrectly rejected EF.Constant and EF.Parameter when their argument is a property on the current DbContext. The fix permits only operands that have been transformed into a context accessor and preserves rejection for literal and other non-context operands.

Customer impact
Applications using tenant or similar context state in a global query filter cannot execute affected non-compiled queries on EF Core 11 RC1.

modelBuilder.Entity<Blog>()
    .HasQueryFilter(blog => blog.TenantId == EF.Parameter(TenantId));

The query throws instead of applying the tenant filter. There is no practical workaround other than removing the explicit EF.Parameter or EF.Constant call.

How found
User reported on EF Core 11.0.0-rc1 in #39081. One customer report and one issue reaction indicate affected usage.

Regression
Yes, from EF 10.x. Introduced by #38155.

Testing
Tests added.

Risk
Low. The change is to revert to previous behavior in select cases.

[Copilot]

Copilot review overview

🟡 Changes recommended

The relaxed guards allow non-context operands that later cause InvalidCastException during normalization.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Reject non-context operands when generating context accessors · New

What changed in this PR

Fixes query-filter funcletization for EF.Constant and EF.Parameter over context properties.

Changes:

• Relaxes funcletizer guards during context-accessor generation.
• Adds result and SQL regression coverage.

File	Description
ExpressionTreeFuncletizer.cs	Allows forcing methods in query-filter processing.
AdHocQueryFiltersQueryTestBase.cs	Adds provider-agnostic regression tests.
AdHocQueryFiltersQuerySqlServerTest.cs	Verifies constantized and parameterized SQL.

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Two new inherited tests lack required SQL Server overrides, causing Check_all_tests_overridden to fail.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Override inherited fact test in SQL Server suite · New

Resolved since last review (1)

• Reject non-context operands when generating context accessors

[Copilot]

Copilot review overview

🔵 Needs a closer look

The shared handler also changes undocumented and untested EF.MultipleParameters behavior.

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Override inherited fact test in SQL Server suite

Previously missed (1)

In code that hasn't changed since last review

Restrict relaxed guard to EF.Constant/EF.Parameter or add coverage

src/​EFCore/​Query/​Internal/​ExpressionTreeFuncletizer.cs:1189

HandleParameter is also used by EF.MultipleParameters (lines 969–973), so this relaxed guard enables context-backed MultipleParameters in query filters too. That behavior is outside the PR’s stated EF.Constant/EF.Parameter scope and has no acceptance or rejection coverage. Either retain the old rejection for MultipleParameters, or explicitly include it in scope and add equivalent context-property and literal tests.