Exclude overrides from ApiChief baselines and deltas - #39093
Open
AndriySvyryd with Copilot wants to merge 2 commits into
Open
AndriySvyryd with Copilot wants to merge 2 commits into
AndriySvyryd with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
September 25, 2026 01:37
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates ApiChief to exclude overridden members from API models and baselines.
Changes:
- Filters overridden methods and properties.
- Adds regression coverage.
- Removes obsolete override declarations from baselines.
| File | Summary |
|---|---|
test/EFCore.ApiBaseline.Tests/ApiBaselineTest.cs |
Adds override regression coverage. |
src/Microsoft.Data.Sqlite.Core/Microsoft.Data.Sqlite.Core.baseline.json |
Removes obsolete overrides. |
src/EFCore/EFCore.baseline.json |
Removes obsolete overrides. |
src/EFCore.SqlServer/EFCore.SqlServer.baseline.json |
Removes obsolete overrides. |
src/EFCore.SqlServer.NTS/EFCore.SqlServer.NTS.baseline.json |
Removes obsolete overrides. |
src/EFCore.SqlServer.HierarchyId/EFCore.SqlServer.HierarchyId.baseline.json |
Removes obsolete overrides. |
src/EFCore.SqlServer.Abstractions/EFCore.SqlServer.Abstractions.baseline.json |
Removes obsolete overrides. |
src/EFCore.Sqlite.NTS/EFCore.Sqlite.NTS.baseline.json |
Removes obsolete overrides. |
src/EFCore.Sqlite.Core/EFCore.Sqlite.Core.baseline.json |
Removes obsolete overrides. |
src/EFCore.InMemory/EFCore.InMemory.baseline.json |
Removes obsolete overrides. |
src/EFCore.Design/EFCore.Design.baseline.json |
Removes obsolete overrides. |
src/EFCore.Cosmos/EFCore.Cosmos.baseline.json |
Removes obsolete overrides. |
eng/Tools/ApiChief/Processing/ApiProcessor.cs |
Filters overridden members. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
AndriySvyryd
marked this pull request as ready for review
September 25, 2026 02:08
AndriySvyryd
requested review from
a team,
AndriySvyryd and
wtgodbe
as code owners
September 25, 2026 02:08
AndriySvyryd
enabled auto-merge (squash)
September 25, 2026 02:08
wtgodbe
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiChief treated overridden members as newly declared API, adding noise to baselines and deltas.
API filtering
IsOverride.Baselines
Regression coverage