Conversation
SqlServerDatabaseModelFactory and SqliteDatabaseModelFactory strip the
surrounding quotes from a string literal default (e.g. `('It''s')`) but leave
the SQL escape sequence `''` in place, so the scaffolded model gets
`HasDefaultValue("It''s")`. The migrations SQL generator then escapes the
value again and emits `DEFAULT N'It''''s'`, changing the default to `It''s`.
Replace `''` with `'` after removing the enclosing quotes in both factories,
and add regression tests covering plain, `N`-prefixed, `CONVERT`-wrapped and
single-quote-only literals.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SqlServerDatabaseModelFactory and SqliteDatabaseModelFactory strip the surrounding quotes from a string literal default (e.g.
('It''s')) but leave the SQL escape sequence''in place, so the scaffolded model getsHasDefaultValue("It''s"). The migrations SQL generator then escapes the value again and emitsDEFAULT N'It''''s', changing the default toIt''s.Replace
''with'after removing the enclosing quotes in both factories, and add regression tests covering plain,N-prefixed,CONVERT-wrapped and single-quote-only literals.