Use Process.MainModule to find the dotnet muxer - #233
Merged
Conversation
pranavkm
approved these changes
May 24, 2017
| var muxerPath = DotNetMuxer.MuxerPath; | ||
| Assert.NotNull(muxerPath); | ||
| Assert.True(File.Exists(muxerPath), "The file did not exist"); | ||
| Assert.True(Path.IsPathRooted(muxerPath), "The path should be rooted"); |
There was a problem hiding this comment.
Could you also add a Assertion that says the file name is dotnet.exe? Just so we know in case they ever break us.
Author
There was a problem hiding this comment.
Will do. On second thought, it would be good to add this to the DotNetMuxer too. Process.MainModule will return the path to corehost in standalone mode ( which is typically renamed to MyAppName.exe). This is muxer, so we should fallback to "dotnet" on PATH in that case.
natemcmaster
pushed a commit
that referenced
this pull request
Nov 5, 2018
* Modify PhysicalFileWatcher.Watch to work for new files being added Fixes #233
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion on https://github.com/dotnet/core-setup/issues/2473, it appears Process.MainModule is a more accurate way to find the path to corehost.
Resolves issues related to multi-hive lookup and aspnet/dotnettools and aspnet/buildtools.