Repository navigation
Conversation
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1635220&view=codecoverage-tab |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty messages after a function approval are removed during extraction but were still counted when positioning the reconstructed function calls and results. This moves the block ahead of earlier conversation messages, or produces a negative insertion index when several empty messages follow the approval.
Count only non-empty trailing messages. Extend the existing approval-order tests with zero, one and three trailing empty messages, covering client-managed and service-managed history, residual approval-message content, and both streaming and non-streaming calls.
Fixes #7834.
Validation: the eight added empty-message cases fail before the fix. Afterward, all 776 tests in Microsoft.Extensions.AI.Tests pass on net10.0. Microsoft.Extensions.AI builds for net8.0, net9.0, net10.0, net462 and netstandard2.0 with no warnings or errors.
Microsoft Reviewers: Open in CodeFlow