Repository navigation
Surface usage and finish reason on response.incomplete - #7895
jaeminbird wants to merge 1 commit into
Conversation
Fixes dotnet#7893 The Responses streaming adapter treated response.incomplete like an in-progress event, so a stream that stopped at max_output_tokens or on a content filter reported no usage and no finish reason. The event is terminal, like response.completed, so map its usage and incomplete reason the same way the non-streaming path does.
|
@jaeminbird please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1653868&view=codecoverage-tab |
valkiara
left a comment
There was a problem hiding this comment.
Reviewed 79a424b. The adapter test project passed on net10.0 with SDK 10.0.401: 397 passed, 163 skipped with live integration tests disabled.
Seven local SSE cases also passed, covering max_output_tokens and content_filter with and without usage, null incomplete details, and store:false. I checked that partial text is not duplicated, usage is emitted once with cached/reasoning token counts preserved, and the terminal update retains its response/message IDs, role, model, timestamp and conversation behavior. The reason mapping matches the non-streaming path.
No issues found in the changed terminal-event handling.
Fixes #7893.
response.incompleteis a terminal event sent instead ofresponse.completed, but the streaming adapter treated it likeresponse.in_progress, so a stream cut off bymax_output_tokensor a content filter reported noUsageContentand noFinishReason. It now maps usage and the incomplete reason the same way the non-streaming path does.Validation: the new test fails before the fix (
FinishReasonis null) and passes after;Microsoft.Extensions.AI.OpenAI.Tests(net10.0) pass, and the Release build for all target frameworks is clean.Microsoft Reviewers: Open in CodeFlow