AttributeUsage doesn't distinguish AttributeTargets.Class and AttributeTargets.Struct #13526

Activity

1. auduchinok

   added

   Bug

   on Jul 19, 2022
2. vzarytovskii

   added this to F# Compiler and Toolingon Sep 9, 2022
3. vzarytovskii

   moved this to Not Planned in F# Compiler and Toolingon Sep 9, 2022
4. vzarytovskii

   modified the milestones: September-2022, Backlog on Sep 9, 2022
5. vzarytovskii

   added

   Area-Compiler-CheckingType checking, attributes and all aspects of logic checkingType checking, attributes and all aspects of logic checking

   on Sep 9, 2022
6. dsyme commented on Sep 21, 2022

   

   dsyme

   on Sep 21, 2022

   Contributor

   More actions

   @auduchinok Could you check the title of this bug please? It says .Constructor but doesn't mention that in the description?

   Seems there are three problems:

   • CustomStruct can be targeted at class incorrectly
   • CustomClass can be targeted at struct incorrectly
   • CustomMethod can be targeted at a constructor incorrectly

   This seem ok:

   • CustomConstructor can't be targeted at a method

   Example this works but shouldn't:

   open System
   [<AttributeUsage(AttributeTargets.Method)>]
   type CustomMethodAttribute() =
       inherit Attribute()
   
   type Class [<CustomMethod>] () = class end
   
   type Struct [<CustomMethod>] (x: int) = struct end```
   and this works (as expected:
   ```fsharp
   
   [<AttributeUsage(AttributeTargets.Constructor)>]
   type CustomConstructorAttribute() =
       inherit Attribute()
   
   type Class [<CustomConstructor>] () = class end
   
   type Struct [<CustomConstructor>] (x: int) = struct end
7. dsyme

   added

   good first issue

   Impact-Low(Internal MS Team use only) Describes an issue with limited impact on existing code.(Internal MS Team use only) Describes an issue with limited impact on existing code.

   on Sep 21, 2022
8. auduchinok commented on Sep 22, 2022

   

   auduchinok

   on Sep 22, 2022

   MemberAuthor

   More actions

   @dsyme Yes, I think it was about structs.
9. auduchinok

   changed the title [-]`AttributeUsage` doesn't distinguish `AttributeTargets.Class` and `AttributeTargets.Constructor`[/-] [+]`AttributeUsage` doesn't distinguish `AttributeTargets.Class` and `AttributeTargets.Struct`[/+] on Sep 22, 2022
10. vzarytovskii

    added

    help wanted

    on Nov 7, 2022
11. edgarfgp

    self-assigned this

    on Feb 27, 2024
12. psfinaki

    closed this as completedin #16790on Mar 13, 2024
13. github-project-automation

    moved this from New to Done in F# Compiler and Toolingon Mar 13, 2024