Blockstructure lines are a bit weird

[forki]

/cc @cloudRoutine

[forki]

why is this first line shown. we already have a solid line over there

[saul]

Here's two more:

1. Class where the constructor arguments are on a new line.
2. Computation expressions. The guide line seems to start at the opening brace.

[saul]

/cc @vasily-kirichenko as you did some fixes for the block structuring recently.

[vasily-kirichenko]

@saul that was not me, that was @cloudRoutine (and he is the original author of all the code ported from VFPT).

[saul]

Sorry - wasn't implying that you broke it - just that you may know of the fix :)

[cartermp]

Classifying this set of bugs as urgency-soon. Although it certainly doesn't break people, some of the above things look weird enough to justify trying to get this in for release.

[cartermp]

If we can't get some of these fixes in for release, we should definitely discuss turning the feature off.

[vasily-kirichenko]

@saul are you sure you test the latest version from master? I cannot reproduce you issues:

[saul]

Definitely not on latest master - I've been refraining from updating over the past few days because of #1825

If you can't reproduce on master then please ignore my comment. I can consistently reproduce it on every computation expression.

[vasily-kirichenko]

FYI

It turns out, there is a global setting which turns on / off guidelines (not block collapsing, but just guidelines):

So annoyed people will be able to turn it off.

[saul]

Vasily have you any idea why the extra guidelines are shown for multi-line pattern match cases? My issue that was closed as dupe has a minimal repro: #2191