Skip to content

Cannot debug VFT inself anymore - FSharp.Editor has no PDB file #2771

Closed

Description

@vasily-kirichenko
  • git cleanup
  • deleted c:\Users\me\AppData\Local\Microsoft\VisualStudio\15.0_183b437fFSharpDev
  • deleted c:\Users\me\AppData\Roaming\Microsoft\VisualStudio\15.0_183b437fFSharpDev
  • build vs
  • build VFT solution inside VS
  • Ctrl+F5
  • attached to the exp instance
  • tried to set a breakpoint in several places in FSharp.Editor and FSharp.Language.Service

image

Activity

  1. forki commented on Apr 2, 2017

    @forki
    Contributor
  2. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    wow :((

  3. forki commented on Apr 2, 2017

    @forki
    Contributor
  4. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    I think the big diff was switching to more nuget VS packages instead of GAC deps.

  5. forki commented on Apr 2, 2017

    @forki
    Contributor

    Sigh.
    I think @cloudRoutine said something about nuget packages messing up his editor support yesterday. Why is this shit never working?
    OK so what now? Can you reset before that and confirm it broke us?

  6. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    image

  7. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    I'm completely stuck on working on VFT at the moment :(

  8. cloudRoutine commented on Apr 2, 2017

    @cloudRoutine
    Contributor



    tried adding

    <IncludeDebugSymbolsInVSIXContainer>true</IncludeDebugSymbolsInVSIXContainer>
      <IncludeDebugSymbolsInLocalVSIXDeployment>true</IncludeDebugSymbolsInLocalVSIXDeployment>

    to visualfsharpopensource.csproj, only seemed to make symbols load faster

    after disabling just my code in debug settings

    Changing the setting suggested in the image below made no difference

  9. cloudRoutine commented on Apr 2, 2017

    @cloudRoutine
    Contributor

    After trying to set a breakpoint crashed VS

    I was able to set some breakpoints that came up as invalid while loading the experimental instance once it was actually running

  10. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    I looked at what FSharp.Editor.dll is actually loaded and there no *.pdb in that folder at all:

    image

  11. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    I've copied *.pdb manually, it's not helped.

  12. vasily-kirichenko commented on Apr 2, 2017

    @vasily-kirichenko
    ContributorAuthor

    'devenv.exe' (CLR v4.0.30319: DefaultDomain): Loaded 'C:\USERS\VASKI\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_183B437FFSHARPDEV\EXTENSIONS\MICROSOFT.VISUALFSHARPTOOLS\VISUAL F# TOOLS\42.42.42.42\FSharp.Editor.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.

    Why the hell it's optimized??

  13. sergey-tihon commented on Apr 2, 2017

    @sergey-tihon
    Contributor

    not sure if it is related, but after update to latest nightly, VS2017 asked to install some VS updates ...
    After installation I cannot open solutions with F# projects and I found that VFT extension is disables

    I can not do anything about it for now...
    vft-disabled

  14. cartermp commented on Apr 2, 2017

    @cartermp
    Contributor

    @sergey-tihon Can you run VSIXInstaller to remove the nightly and load F# projects after that? (It should be using the vs2017 RTW version of the tools).

  15. changed the title [-]Cannot debug VFT inself anymore[/-] [+]Cannot debug VFT inself anymore - FSharp.Editor has no PDB file[/+] on Apr 2, 2017
  16. cloudRoutine commented on Apr 2, 2017

    @cloudRoutine
    Contributor
  17. cloudRoutine commented on Apr 2, 2017

    @cloudRoutine
    Contributor

    switching back to my navigable-improvements branch/PR and the problem disappears

    so the problem should be within
    cloudRoutine/fsharp@navigable-improvements...cloudRoutine:master

  18. 0x53A commented on Apr 2, 2017

    @0x53A
    Contributor

    There seems to be an issue with portable PDBs:

    After disabling optimizations and setting DebugType: full, all breakpoints bind, and all except two (the marked lines) also actually hit.

    master...0x53A:debuggable

    image

    I had to disable sourcelink, because sourcelink only works with portable pdbs.

    With optimizations enabled, some breakpoints wouldn't bind, but the ones that bound then also got hit.

  19. majocha commented on Apr 3, 2017

    @majocha
    Contributor

    Thanks @0x53A ! It started to work with your fix, but only after another git clean.

  20. 0x53A commented on Apr 3, 2017

    @0x53A
    Contributor

    @majocha you don't need to clean, but you need to change anything in any file, because the up-to-date check doesn't check the FSharpSource.Settings.targets, and so doesn't rebuild by default. I always just added/removed one space in FSharp.Editor when testing this.

  21. forki commented on Apr 3, 2017

    @forki
    Contributor

    clean is often needed if you want to rebuild proto or when nuget fucked up again.

  22. forki commented on Apr 4, 2017

    @forki
    Contributor

    This is really really painful

  23. majocha commented on Apr 4, 2017

    @majocha
    Contributor

    Yeah, I'm totally blocked again. Breakpoints fail to bind.

  24. added
    Impact-High(Internal MS Team use only) Describes an issue with extreme impact on existing code.
    on Apr 4, 2017
  25. cartermp commented on Apr 4, 2017

    @cartermp
    Contributor

    cc @KevinRansom @brettfo - this has to be resolved quickly.

  26. vasily-kirichenko commented on Apr 8, 2017

    @vasily-kirichenko
    ContributorAuthor

    Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugContributor PainImpact-High(Internal MS Team use only) Describes an issue with extreme impact on existing code.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions