Repository navigation
Go To Definition - f12 fails, tooltip works #5521
Description
If you F12 on a symbol in another file, it can't navigate to the item. However, if you click the type in the tooltip that follows, it works.
{{ message }}
If you F12 on a symbol in another file, it can't navigate to the item. However, if you click the type in the tooltip that follows, it works.
Activity
realvictorprm commentedon Aug 16, 2018
I already experienced that in a Fable project with 15.7 .
In 15.8 it still doesn't work there but it works for me on a backend project so looks like it's bound to specific circumstances?
cartermp commentedon Aug 16, 2018
@isaacabraham can you provide some more details or upload a repro solution?
Using 15.8, .NET Core project:
fsx-to-fs in a .NET Framework project:
cartermp commentedon Aug 17, 2018
@isaacabraham Do you have a repro? I used this throughout the VF# codebase yesterday and could not get GTD to fail.
isaacabraham commentedon Aug 22, 2018
I've managed to get a repro in an existing project. The only thing I can see that might be the cause is that the symbol I'm trying to go to definition on lives in a linked
.fsfile in the project, rather than a normal project file.isaacabraham commentedon Aug 22, 2018
I can also reproduce on a script where I'm loading in an
.fsfile and trying to go to definition of a symbol defined in that. It works if I click on the symbol link in the tooltip, but not with F12.0x53A commentedon Aug 22, 2018
I've seen the same in safe bookstore - f12 mostly doesn't work, the clickable tooltips do
cartermp commentedon Aug 22, 2018
@isaacabraham in the second GIF, I'm doing the same as this:
But it succeeds. Do you have a repro?
I'll take a look at the fable bookstore, which uses linked files.
isaacabraham commentedon Aug 22, 2018
@cartermp this is then something either environmental - my install of 15.8.1 is somehow borked, or something specific with the project. But I can't see anything there else unusual - it's a netcore2.0 console app.
There's definitely something different in the behaviour of Go To Definition when hitting F12 compared to clicking the hyperlink in the tooltip, because the latter works whilst F12 doesn't.
vasily-kirichenko commentedon Aug 22, 2018
@isaacabraham The implementation of go to def and links on the tooltip are completely different (and surprisingly complicated).
cartermp commentedon Aug 22, 2018
@isaacabraham I just tried with a .NET Core 2.1 console app with a script that navigates to a symbol in a source file for that project: works with f12, ctrl+click, and tooltip go to definition.
forki commentedon Aug 22, 2018
So zip with repro it is. Like always...
cartermp commentedon Aug 22, 2018
Okay, so the issue is when you attempt to go to definition from one linked file to another. Example:
Home.fs-->viewLinksymbolTooltip shows and you can go to definition, but cannot use f12 or ctrl+click (which share the same implementation).
If files are "normal", or you're going to definition within a linked file, or going to definition between linked/non-linked files, everything seems to work.
I also noticed that finding symbols for Find Refs or Rename is inconsistent in this project. For example:
Wishlist/Msg:Not a linked file, and the references live in the same file.
Database/DatabaseType:Not a linked file, and all references live in the same file.
Bug: #5545
10 remaining items
isaacabraham commentedon Jun 18, 2019
I can confirm that this problem still exists in the latest master of the Azure Storage TP.
[-]Go To Definition in 15.8 is broken again when linked files are used[/-][+]Go To Definition - f12 fails, tooltip works[/+]cartermp commentedon Aug 9, 2019
Noting this in two additional areas:
zanaptak commentedon Aug 9, 2019
In the Azure TP it's the forward slashes #4016
cartermp commentedon Aug 9, 2019
Fixed by #7376