chore(Async.RunSynchronouslyImmediate): Stragglers re #19804 - #20245
Merged
Merged
Conversation
Contributor
|
bartelink
force-pushed
the
rsi-stragglers
branch
from
August 11, 2026 15:49
d4b57da to
862a6b0
Compare
bartelink
changed the title
bartelink
marked this pull request as ready for review
August 11, 2026 15:51
Contributor
Author
|
@T-Gro want me to propagate that changelog entry to VS release notes like the comment says? |
There was a problem hiding this comment.
Pull request overview
This PR finishes the Async.RunImmediate → Async.RunSynchronouslyImmediate rename across VS integration code/tests and updates helper APIs to match the new naming and behavior (notably exception unwrapping).
Changes:
- Replace remaining
Async.RunImmediateusages in VS integration and Salsa tests withAsync.RunSynchronouslyImmediate. - Rename
RunImmediateExceptOnUItoRunSynchronouslyImmediateExceptOnUIand delegate toAsync.RunSynchronouslyImmediate. - Update benchmarks/source payloads and release notes to reflect the rename.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vsintegration/tests/Salsa/salsa.fs | Rename call sites to Async.RunSynchronouslyImmediate. |
| vsintegration/tests/Salsa/FSharpLanguageServiceTestable.fs | Rename NotifyProjectCleaned call site to Async.RunSynchronouslyImmediate. |
| vsintegration/tests/FSharp.Editor.Tests/BraceMatchingServiceTests.fs | Update tests to use RunSynchronouslyImmediateExceptOnUI. |
| vsintegration/src/FSharp.LanguageService/LanguageServiceConstants.fs | Introduces a shim for RunSynchronouslyImmediate (currently problematic). |
| vsintegration/src/FSharp.LanguageService/FSharpSource.fs | Rename parse call site to Async.RunSynchronouslyImmediate. |
| vsintegration/src/FSharp.LanguageService/BackgroundRequests.fs | Rename various checker call sites to Async.RunSynchronouslyImmediate. |
| vsintegration/src/FSharp.Editor/Common/Extensions.fs | Rename helper and delegate to Async.RunSynchronouslyImmediate off-UI thread. |
| tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/SomethingToCompileSmaller.fs | Updates embedded source; currently introduces a syntax error + duplicate member. |
| tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/SomethingToCompile.fs | Updates embedded source; currently defines a duplicate member. |
| docs/release-notes/.FSharp.Compiler.Service/11.0.100.md | Adds PR reference to existing entry (minor formatting issue). |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
- rename and sync clone impls withing VisualFSharp.slnx as per previous PR - update RunImmediateExceptOnUI to delegate and follow naming
bartelink
force-pushed
the
rsi-stragglers
branch
from
August 11, 2026 21:06
862a6b0 to
7e1cbd4
Compare
bartelink
force-pushed
the
rsi-stragglers
branch
from
August 11, 2026 21:10
7e1cbd4 to
38d2246
Compare
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Aug 12, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followups to fsharp/fslang-suggestions#1042 (from fsharp/fslang-suggestions#1042) via #19844 (comment)
VisualFSharp.slnxas per previous PRRunImmediateExceptOnUIto delegate to RSI and follow namingChecklist