Repository navigation
[MicroPerf] Drop accessibility and attribute-scan closures via ListInline - #20421
Merged
Merged
Conversation
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
force-pushed
the
t-gro-list-hof-closure-spike
branch
from
September 9, 2026 08:54
2af10a1 to
2612cfb
Compare
abonie
approved these changes
Sep 9, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
abonie
previously approved these changes
Sep 9, 2026
T-Gro
force-pushed
the
t-gro-accessibility-attr-listinline
branch
from
September 9, 2026 10:09
0de618b to
beab672
Compare
…line Add inline ListInline.forall/tryFind and route the hot accessibility and attribute-scan checks through the inline ListInline twins so the predicates are inlined (InlineIfLambda) rather than allocated as per-call closures. Rebased onto main after the ListInline base (#20372) merged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 17e33363-3dfc-4cf9-9c44-a64686bd5ad1
T-Gro
force-pushed
the
t-gro-accessibility-attr-listinline
branch
from
September 9, 2026 12:46
beab672 to
bf73bc8
Compare
Contributor
|
abonie
approved these changes
Sep 9, 2026
This was referenced Sep 11, 2026
bartelink
pushed a commit
to bartelink/fsharp
that referenced
this pull request
Oct 7, 2026
…line (dotnet#20421) Add inline ListInline.forall/tryFind and route the hot accessibility and attribute-scan checks through the inline ListInline twins so the predicates are inlined (InlineIfLambda) rather than allocated as per-call closures. Rebased onto main after the ListInline base (dotnet#20372) merged. Co-authored-by: perf-bundle <perf@local> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 17e33363-3dfc-4cf9-9c44-a64686bd5ad1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #20372 (adds the internal
ListInlinemodule). Extends it withexists/forall/tryFind(inline+InlineIfLambda) and routes five hot accessibility / attribute-scan call sites through them, folding the lambda so no per-callFSharpFuncclosure is allocated.Closure allocation removed —
dotnet-trace gc-verbose,fscself-compilingsrc/Compiler(net11 perf bundle):IsAccessibleListInline.existscanAccessFromListInline.foralltryFindEntityAttribByFlag/tryFindValAttribByFlagListInline.tryFind/existscanAccessFromOneOf's closure is folded too.Deterministic proof — closure classes
IsAccessible@,canAccessFrom@,canAccessFromOneOf@,tryFindEntityAttribByFlag@,tryFindValAttribByFlag@are present in the baseFSharp.Compiler.Service.dlland absent after (metadata scan of the emitted assembly).exists/forall/tryFindmatchList.*semantics (empty →false/true/None, first match preserved); build 0/0.