Repository navigation
Remove the ArithmeticInLiterals language feature flag - #20430
Merged
Merged
Conversation
Remove the always-true suppressLangFeatureCheck threading and checkFeature helper from EvalAttribArgExpr, and delete the now-unused SuppressLanguageFeatureCheck type. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The feature shipped in F# 8.0 and the minimum selectable --langversion is now 8.0, so the flag is permanently enabled dead configuration (#20176). Delete the LanguageFeature DU case, its features-map entry and GetFeatureString arm, the featureArithmeticInLiterals resource string, and regenerate the xlf translation files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
T-Gro
added
the
NO_RELEASE_NOTES
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
T-Gro
enabled auto-merge (squash)
September 3, 2026 12:58
T-Gro
added
NO_RELEASE_NOTES
abonie
approved these changes
Sep 4, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
This was referenced Sep 4, 2026
bartelink
pushed a commit
to bartelink/fsharp
that referenced
this pull request
Oct 7, 2026
* Collapse ArithmeticInLiterals enforcement site Remove the always-true suppressLangFeatureCheck threading and checkFeature helper from EvalAttribArgExpr, and delete the now-unused SuppressLanguageFeatureCheck type. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove the ArithmeticInLiterals language feature flag and its resources The feature shipped in F# 8.0 and the minimum selectable --langversion is now 8.0, so the flag is permanently enabled dead configuration (dotnet#20176). Delete the LanguageFeature DU case, its features-map entry and GetFeatureString arm, the featureArithmeticInLiterals resource string, and regenerate the xlf translation files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20176
ArithmeticInLiteralshas been on for every accepted--langversionsince F# 8.0, so its flag could never be turned off. Removed the dead feature and collapsed the guarded literal/enum/attribute evaluation to its enabled path.--disableLanguageFeature:ArithmeticInLiteralsis no longer a recognised feature name.Part of #20139