Skip to content

Remove always-on RequiredPropertiesSupport flag - #20517

Merged
T-Gro merged 2 commits into
mainfrom
fix/issue-20172
Sep 16, 2026
Merged

T-Gro merged 2 commits into
mainfrom
fix/issue-20172

Conversation

@T-Gro

@T-Gro T-Gro commented Sep 10, 2026

Copy link
Copy Markdown
Member

Fixes #20172

Make required-member and init-only property checks unconditional by removing the always-on RequiredPropertiesSupport feature flag.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro requested a review from a team as a code owner September 10, 2026 21:41
@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Sep 10, 2026
@T-Gro
T-Gro enabled auto-merge (squash) September 14, 2026 13:07
@T-Gro
T-Gro requested a review from abonie September 14, 2026 13:07

@abonie abonie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖🕵️ LGTM ✅

Dimensions covered (expand)
  • Test coverage
  • Type system correctness
  • Feature gating and backward compatibility
  • Overload resolution and struct semantics
  • Diagnostic quality and localization
  • FCS API surface

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Sep 16, 2026
@T-Gro
T-Gro merged commit 721adfa into main Sep 16, 2026
52 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Sep 16, 2026
@abonie abonie added the AI-reviewed PR reviewed by AI review council label Sep 16, 2026
bartelink pushed a commit to bartelink/fsharp that referenced this pull request Oct 7, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-reviewed PR reviewed by AI review council AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: RequiredPropertiesSupport

2 participants