Float v.s float #1669

Activity

1. tannergooding commented on Nov 19, 2018

   

   tannergooding

   on Nov 19, 2018

   Last edited by tannergooding

   Member

   More actions

   The .NET Design guidelines indicate we should use the language keyword (float) everywhere except for API names, where we should use the non-language specific name (Single):

   For example:

   public static class BitConverter
   {
       public static float Int32BitsToSingle(int bits);
       public static int SingleToInt32Bits(float value);
   }

   CC. @eerhardt
2. Ivanidzo4ka commented on Nov 19, 2018

   

   Ivanidzo4ka

   on Nov 19, 2018

   Contributor

   More actions

   @wschin we are trying to get rid of Float in our code, and if you look into estimators PRs we almost always delete that using Float = System.Single; line and use float instead
3. TomFinley commented on Nov 19, 2018

   

   TomFinley

   on Nov 19, 2018

   Contributor

   More actions

   Just some history, in the long vanished past we used to have two builds, a "double" and a "single" build. (This was in the days before IDataView where pipelines could accommodate either.) But, when we removed the compiler switch, it was beneficial to keep the declaration around: by doing so you only had a couple thousand lines changed, instead of tens of thousands of lines changed.

   We've been opportunistically removing Float though, though in a very very piecemeal fashion. Doing it all at once though -- well, it might be a good idea, but that would be one heck of a PR to manage conflicts on. 😛
4. Zruty0 commented on Nov 20, 2018

   

   Zruty0

   on Nov 20, 2018

   Contributor

   More actions

   Yes, just recently I saw someone mass-renaming Single to float, and ending up with Ldafloatbox somewhere in comments :)
5. shmoradims

   added

   answered

   on Nov 26, 2018
6. glebuk commented on Jan 14, 2019

   

   glebuk

   on Jan 14, 2019

   Contributor

   More actions

   Seems to be fixed already
7. glebuk

   closed this as completedon Jan 14, 2019
8. Ivanidzo4ka commented on Jan 14, 2019

   

   Ivanidzo4ka

   on Jan 14, 2019

   Contributor

   More actions

   Not exactly finished.
   

   machinelearning/src/Microsoft.ML.StandardLearners/Optimizer/LineSearch.cs

   Line 8 in a570da1

   using Float = System.Single;

   
   We have still plenty of places where we have using Float = System.Single; pattern.

   In many places we clean it up via different unrelated PRs, but some code haven't been touch since we merge it from internal repo.
9. sfilipi

   reopened this on Feb 6, 2019
10. sfilipi commented on Feb 6, 2019

    

    sfilipi

    on Feb 6, 2019

    Member

    More actions

    The action item on this PR is to remove

    using Float = System.Single from all the files, and through the codebase, replace Float, with float.
11. sfilipi

    added

    good first issueGood for newcomersGood for newcomers

    up-for-grabs

    nit

    and removed

    answered

    on Feb 6, 2019
12. shauheen

    added

    assigned

    on Feb 27, 2019
13. shauheen

    added this to the 0219 milestone on Feb 28, 2019
14. shauheen

    closed this as completedon Mar 5, 2019
15. Dmitry-A

    added a commit that references this issue on Apr 13, 2019

    code migration from machinelearning-automl to machinelearning repo fe…

    ...

    1702658
16. Dmitry-A

    added a commit that references this issue on Aug 22, 2019

    Random number generator is not thread safe (dotnet#310)

    ...

    04cc2d4
17. harishsk

    added 2 commits that reference this issue on Sep 6, 2019

    Added onnx export functionality for LpNormNormalizingTransformer (#4161)

    ...

    bc16b1d

    Added Onnx export functionality to PCATransformer (#4188)

    ...

    42e39b9
18. ghost locked as resolved and limited conversation to collaborators on Mar 26, 2022