Skip to content

Hyperparameters reversed in Scenario3  #25

New issue
New issue
Closed
Closed
Hyperparameters reversed in Scenario3 #25
Labels
good first issueGood for newcomers
Milestone
0518

Description

@maryamariyan
maryamariyan
opened on May 4, 2018

From @justinormont on May 2, 2018, 8:51 AM PDT

Line below on file machinelearning/test/Microsoft.ML.Tests/Scenarios/Scenario3_SentimentPrediction.cs

CharFeatureExtractor = new NGramNgramExtractor() { NgramLength = 2, AllLengths = true },

Currently: (trigrams & unichargrams+bichargrams)

  CharFeatureExtractor = new NGramNgramExtractor() { NgramLength = 2, AllLengths = true },
  WordFeatureExtractor = new NGramNgramExtractor() { NgramLength = 3, AllLengths = false }

Should be: (unigram+bigram & trichargrams)

  CharFeatureExtractor = new NGramNgramExtractor() { NgramLength = 3, AllLengths = false },
  WordFeatureExtractor = new NGramNgramExtractor() { NgramLength = 2, AllLengths = true }

Activity

  1. GalOshri
    added
    good first issueGood for newcomers
    on May 5, 2018
  2. shauheen
    added this to the 0518 milestone on May 8, 2018
  3. glebuk
    closed this as completedin #94on May 10, 2018
  4. glebuk
    added a commit that references this issue on May 10, 2018

    Fix reversed hyperparameters in Scenarios Tests. Closes #25. (#94)

    ff5fb14
  5. eerhardt
    added a commit that references this issue on Jul 27, 2018

    Fix reversed hyperparameters in Scenarios Tests. Closes dotnet#25. (d…

    7ba8617
  6. Dmitry-A
    added 2 commits that reference this issue on Apr 12, 2019

    add conversions tests (dotnet#25)

    5caf142

    code migration from machinelearning-automl to machinelearning repo fe…

    1702658
  7. Dmitry-A
    added a commit that references this issue on Aug 22, 2019

    add conversions tests (dotnet#25)

    962627f
  8. ghost locked as resolved and limited conversation to collaborators on Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions