Repository navigation
Public API for SchemaDefinition class #2978
Description
There are no samples/tests in the code that make use of this class, even though it is part of the public API.
Metadata
Metadata
Assignees
Labels
No labels
{{ message }}
There are no samples/tests in the code that make use of this class, even though it is part of the public API.
Activity
yaeldekel commentedon Mar 15, 2019
Also, I think this class should be cleaned up. For example:
The property
IsComputed- should it be internalized/removed?The property
ReturnType- looks like it should be internal.GetAnnotationTypesis a property, so should be renamed.TomFinley commentedon Mar 15, 2019
Yes, I agree with that strongly... we previously used it I think for two purposes, this before we were writing ML.NET, one was something for the user to "talk to" to tell it what it wanted done, the second was for the
PredictionEngineitself to inspect to figure out what should be done, and I don't think we were, at the time, terribly discriminating about whether something was in the public or internal surface w.r.t. "external" and "interface" code.singlis commentedon Mar 15, 2019
@yaeldekel this sounds like multiple issues relating to API, documentation and tests. Want me to create an issue for each case?
yaeldekel commentedon Mar 18, 2019
Hi @singlis , yes, that would be great. I already have a PR for cleaning up the API for this class that references this issue, so adding an issue for doc/samples is a great idea.
Update FromArrowRecordBatches for dotnet-spark (dotnet#2978)
Move DataFrame to machinelearning (#5641)
Merge from main repository (#1)
Actually merge from main (#2)
Update editor config and format samples (#5893)