You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Shall we unify the file encodings of C# source files? #302
The pull request where this was adopted, dotnet/roslyn#20541, includes the C# Interactive lines used to implement the change. Be aware that in some cases, it may be necessary to manually correct characters that are misinterpreted or have been in the past.
⚠️ It's very important to note that while UTF-8 without BOM is generally the preferred Unicode encoding, it does not work in practice the way one would expect. See dotnet/roslyn#20541 (comment) and dotnet/corefx#1470 (comment) for a couple other cases where this was discussed in the past.
If the team working on this repository would like, I would be happy to submit a pull request to implement this change. Just let me know; since it's a question of code style I would prefer to not offer the change until after it's deemed desirable. 😄
I was messing with this and after applying this to the solution, it also updated some spacing. Is there anything else we want to include that's similar to what the Roslyn project has such as the indent size?
@jwood803 do you still have the branch where you were messing around with this? I realize its been a while, figured it would be worth asking.
How much spacing was updated? It would probably be better to move towards what Roslyn or runtime has. Maybe not all in one PR, we could do it over several, but if you already have this file format issue fixed we could start there.
@michaelgsharp Looking at my branches I don't think I created one for this. I can make these again and do a branch or draft PR for a review or discussion if that works.
Activity
sharwell commentedon Jun 5, 2018
I would recommend using .editorconfig for this. Here's the configuration line from dotnet/roslyn:
https://github.com/dotnet/roslyn/blob/969249c9a2bf6ab6ded98d9e7702e76d5ebd6bf1/.editorconfig#L15
The pull request where this was adopted, dotnet/roslyn#20541, includes the C# Interactive lines used to implement the change. Be aware that in some cases, it may be necessary to manually correct characters that are misinterpreted or have been in the past.
sharwell commentedon Jun 5, 2018
If the team working on this repository would like, I would be happy to submit a pull request to implement this change. Just let me know; since it's a question of code style I would prefer to not offer the change until after it's deemed desirable. 😄
veikkoeeva commentedon Jun 5, 2018
@sharwell 👍 from here, apply other settings too (e.g. the namespace ones). :)
shauheen commentedon Dec 6, 2018
Generally I would agree with adopting what roslyn does. @TomFinley what do you think?
default initialization for ignore columns (dotnet#302)
code migration from machinelearning-automl to machinelearning repo fe…
default initialization for ignore columns (dotnet#302)
Added onnx export functionality for LpNormNormalizingTransformer (#4161)
Added Onnx export functionality to PCATransformer (#4188)
jwood803 commentedon May 5, 2020
I was messing with this and after applying this to the solution, it also updated some spacing. Is there anything else we want to include that's similar to what the Roslyn project has such as the indent size?
cc// @shauheen @sharwell
michaelgsharp commentedon Jul 28, 2021
@jwood803 do you still have the branch where you were messing around with this? I realize its been a while, figured it would be worth asking.
How much spacing was updated? It would probably be better to move towards what Roslyn or runtime has. Maybe not all in one PR, we could do it over several, but if you already have this file format issue fixed we could start there.
jwood803 commentedon Jul 28, 2021
@michaelgsharp Looking at my branches I don't think I created one for this. I can make these again and do a branch or draft PR for a review or discussion if that works.
michaelgsharp commentedon Jul 28, 2021
If you are willing to do it that would be awesome.
rosebyte commentedon Sep 3, 2026
C# source encoding is now standardised as UTF-8 with BOM through
.editorconfig.