Repository navigation
Baseline comparisons with tolerance should not exit when values don't match (#218) - #1420
Conversation
| { | ||
| if(!MatchNumberWithTolerance(firstCollection, secondCollection, digitsOfPrecision)) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
[](start = 33, length = 8)
nit: can you remove this extra spaces?
|
@yaeldekel @Ivanidzo4ka curious why do we want to continue comparing the rest of the baselines, if we already have a failure? |
Hi @sfilipi , consider how the baseline files were produced in the first place, or how they are updated when some systematic change happens. If the failure is deferred till the end of the test, then someone with Beyond Compare or some similar tool can update them all at once. However the failure happens immediately, then some files generated in subsequent steps will not be generated, making updating of baselines a multi-step process, instead of a single step process. |
TomFinley
left a comment
TomFinley
left a comment
There was a problem hiding this comment.
Thank you @feiyun0112 for fixing this annoyance!
ghost
locked as resolved and limited conversation to collaborators
Fix #218
call Fail() with a detailed error message saying which file and which line the error occurred in, and continue comparing the rest of the files in the unit test.