Repository navigation
Addition of the ValueMappingEstimator and ValueMappingTransform. - #1710
Merged
Merged
Conversation
This will be replacing the TermLookupTransform and provide a way to specify the mapping betweeen two values (note this is specified and not trained). A user can specify the mapping by providing a keys list and values list that must be equal in size. The Estimator will then generate a 1-1 mapping based on the two lists. The PR references dotnet#754 which covers the conversion of Transformer to use the new Estimator API.
Member
Author
|
@Ivanidzo4ka @sfilipi - I am thankful for your future code reviews! #Resolved |
singlis
changed the title
singlis
changed the title
singlis
commented
Nov 22, 2018
singlis
commented
Nov 22, 2018
singlis
commented
Nov 22, 2018
singlis
commented
Nov 22, 2018
Ivanidzo4ka
reviewed
Nov 25, 2018
Ivanidzo4ka
reviewed
Nov 25, 2018
Ivanidzo4ka
reviewed
Nov 25, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
sfilipi
reviewed
Nov 27, 2018
Member
Author
|
@Ivanidzo4ka and @sfilipi - I have pushed an update. Can you review when you have a moment? #Resolved |
Ivanidzo4ka
reviewed
Dec 21, 2018
| /// <summary> | ||
| /// Base class that contains the mapping of keys to values. | ||
| /// </summary> | ||
| private abstract class ValueMap |
Contributor
There was a problem hiding this comment.
ValueMap [](start = 31, length = 8)
You have only one child class for this abstract class, is it worth to have it? #ByDesign
Member
Author
There was a problem hiding this comment.
The main issue with combining the two classes and having a single class is the declaration of the ValueMap on the Transformer. It would go from ValueMap _valueMap to ValueMap<TKey, TValue> _valueMap -- this would be OK if TKey and TValue could be used directly, however the ValueMap is constructed based on the column types (which are similar!). Where they differr is when TValue is a vector type. When creating ValueMapping Transformer with an int vector, TValue is still only in. However in the value map its int[].
In reply to: 243464824 [](ancestors = 243464824)
Ivanidzo4ka
reviewed
Dec 21, 2018
Ivanidzo4ka
reviewed
Dec 21, 2018
Ivanidzo4ka
reviewed
Dec 21, 2018
Ivanidzo4ka
reviewed
Dec 21, 2018
Ivanidzo4ka
reviewed
Dec 21, 2018
Ivanidzo4ka
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
sfilipi
reviewed
Dec 21, 2018
Member
Author
|
@Ivanidzo4ka @sfilipi thanks a ton for your feedback! Just need one more approval. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be replacing the TermLookupTransform and provide a way to
specify the mapping betweeen two values (note this is specified and not
trained). A user can specify the mapping by providing a keys list and
values list that must be equal in size. The Estimator will then generate
a 1-1 mapping based on the two lists.
The PR references #754 which covers the conversion of Transformer to use
the new Estimator API.