Repository navigation
Add a binary logistic sample - #2256
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2256 +/- ##
==========================================
- Coverage 71.15% 71.13% -0.02%
==========================================
Files 779 779
Lines 140311 140311
Branches 16047 16047
==========================================
- Hits 99838 99814 -24
- Misses 36021 36045 +24
Partials 4452 4452
|
Ivanidzo4ka
reviewed
Jan 28, 2019
Ivanidzo4ka
reviewed
Jan 28, 2019
Ivanidzo4ka
reviewed
Jan 28, 2019
| .Append(ml.Transforms.Text.FeaturizeText("Text", "TextFeatures")) | ||
| .Append(ml.Transforms.Concatenate("Features", "TextFeatures", "age", "fnlwgt", | ||
| "education-num", "capital-gain", "capital-loss", "hours-per-week")) | ||
| .Append(ml.BinaryClassification.Trainers.LogisticRegression()); |
Contributor
There was a problem hiding this comment.
Would be nice to put this example next to LogisticRegression declaration
Something like this:
Contributor
Author
There was a problem hiding this comment.
Hopefully, I put this in the right place. 🙂
Contributor
There was a problem hiding this comment.
Sorry for been cryptic.
I meant this place:
You put it on top of internal class which doesn't show up in documentation.
In reply to: 251782735 [](ancestors = 251782735)
Contributor
Author
There was a problem hiding this comment.
Apologies, I should have noticed the internal on the class. Should be good now, though.
Member
|
Thanks for adding this @jwood803 |
sfilipi
reviewed
Jan 30, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a binary logistic sample using the adult dataset to update issue #1362
@sfilipi Hopefully, this looks good, but just let me know if anything should be changed.