Skip to content

Remove Microsoft.ML.Featurizers - #6355

Merged
ericstj merged 3 commits into
dotnet:mainfrom
ericstj:removeMLFeaturizers
Oct 7, 2022
Merged

ericstj merged 3 commits into
dotnet:mainfrom
ericstj:removeMLFeaturizers

Conversation

@ericstj

@ericstj ericstj commented Oct 5, 2022

Copy link
Copy Markdown
Member

This component was built on https://github.com/microsoft/featurizerslibrary which is no longer actively developed.

@ericstj
ericstj force-pushed the removeMLFeaturizers branch from 6615943 to e7b8331 Compare October 5, 2022 19:38
@ericstj
ericstj force-pushed the removeMLFeaturizers branch from 994f123 to d5fdac0 Compare October 7, 2022 16:27
@codecov

codecov Bot commented Oct 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6355 (cddfbf5) into main (7d764bb) will decrease coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6355      +/-   ##
==========================================
- Coverage   68.65%   68.51%   -0.15%     
==========================================
  Files        1171     1164       -7     
  Lines      248036   246113    -1923     
  Branches    25736    25554     -182     
==========================================
- Hits       170288   168618    -1670     
+ Misses      71006    70820     -186     
+ Partials     6742     6675      -67     
Flag Coverage Δ
Debug 68.51% <ø> (-0.15%) ⬇️
production 62.93% <ø> (-0.12%) ⬇️
test 89.02% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...crosoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs 98.45% <ø> (-0.01%) ⬇️
src/Microsoft.ML.FastTree/Training/StepSearch.cs 57.42% <0.00%> (-4.96%) ⬇️
src/Microsoft.Data.Analysis/DataFrame.IO.cs 79.88% <0.00%> (-1.39%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 85.74% <0.00%> (-1.14%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.36% <0.00%> (-1.02%) ⬇️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 73.49% <0.00%> (-0.27%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.61% <0.00%> (-0.16%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.38% <0.00%> (-0.15%) ⬇️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100.00% <0.00%> (+20.51%) ⬆️

@ericstj

ericstj commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

This should be good to go now. Can I have a review @michaelgsharp or @tarekgh?

@tarekgh tarekgh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all removed components are covered in https://github.com/microsoft/featurizerslibrary. Thanks!

@ericstj
ericstj merged commit 8475fe0 into dotnet:main Oct 7, 2022
ericstj added a commit that referenced this pull request Oct 12, 2022
* Remove Microsoft.ML.Featurizers

* Remove reference to featurizers assembly

* Remove entrypoints for Featurizers from test data.
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants