Repository navigation
Remove Microsoft.ML.Featurizers - #6355
Merged
Merged
Conversation
ericstj
force-pushed
the
removeMLFeaturizers
branch
from
October 5, 2022 19:38
6615943 to
e7b8331
Compare
ericstj
force-pushed
the
removeMLFeaturizers
branch
from
October 7, 2022 16:27
994f123 to
d5fdac0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6355 +/- ##
==========================================
- Coverage 68.65% 68.51% -0.15%
==========================================
Files 1171 1164 -7
Lines 248036 246113 -1923
Branches 25736 25554 -182
==========================================
- Hits 170288 168618 -1670
+ Misses 71006 70820 -186
+ Partials 6742 6675 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
This should be good to go now. Can I have a review @michaelgsharp or @tarekgh? |
tarekgh
approved these changes
Oct 7, 2022
tarekgh
left a comment
Member
There was a problem hiding this comment.
LGTM assuming all removed components are covered in https://github.com/microsoft/featurizerslibrary. Thanks!
ericstj
added a commit
that referenced
this pull request
Oct 12, 2022
* Remove Microsoft.ML.Featurizers * Remove reference to featurizers assembly * Remove entrypoints for Featurizers from test data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component was built on https://github.com/microsoft/featurizerslibrary which is no longer actively developed.