Repository navigation
add WarningsAsMessages, WarningsAsErrors, WarningsNotAsErrors and Tre… - #10942
Merged
SimaTian merged 10 commits intoNov 20, 2024
Merged
Conversation
…atWarningsAsErrors to the engine (e.g. variant without prefix). test those so that nothing breaks
maridematte
approved these changes
Nov 7, 2024
Optionally capture output in BuildProjectExpectFailure for better test diagnosability.
rainersigwald
left a comment
rainersigwald
left a comment
Member
There was a problem hiding this comment.
Pushed some changes to caputre more information from the tests you added (it wasn't done in the bulk of tests here but for new and modified tests I really want to push for capturing stuff, to improve diagnosability when they fail).
JanKrivanek
requested changes
Nov 8, 2024
JanKrivanek
left a comment
JanKrivanek
left a comment
Member
There was a problem hiding this comment.
This looks good
The reason I'm requesting changes is some code repetition that should be easy to extract; plus a bit confusing unit tests
JanKrivanek
approved these changes
Nov 18, 2024
JanKrivanek
left a comment
JanKrivanek
left a comment
Member
There was a problem hiding this comment.
Looks good!
I have couple comments for consideration
Member
Contributor
Author
|
#10873 yes, the other one I'm not sure but it looks similar enough. @rainersigwald ? |
SimaTian
deleted the
respect-warningsAsErrors-and-others-without-prefix
branch
November 20, 2024 11:09
Member
|
Yes, it fixes both of those. |
Member
|
/backport to vs17.12 |
Contributor
|
Started backporting to vs17.12: https://github.com/dotnet/msbuild/actions/runs/11935160959 |
Contributor
|
@rainersigwald backporting to vs17.12 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: add WarningsAsMessages, WarningsAsErrors, WarningsNotAsErrors and TreatWarningsAsErrors to the engine (e.g. variant without prefix). test those so that nothing breaks
Applying: Optional output in BuildProjectExpectFailure
Applying: Capture output logging in new tests
Applying: working through the review. Some test improvements. Changewave used. Comments.
error: sha1 information is lacking or useless (src/Build/BackEnd/Components/RequestBuilder/RequestBuilder.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0004 working through the review. Some test improvements. Changewave used. Comments.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@rainersigwald an error occurred while backporting to vs17.12, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
rainersigwald
added a commit
that referenced
this pull request
Nov 21, 2024
#10942) * add WarningsAsMessages, WarningsAsErrors, WarningsNotAsErrors and TreatWarningsAsErrors to the engine (e.g. variant without prefix). test those so that nothing breaks * Optional output in BuildProjectExpectFailure Optionally capture output in BuildProjectExpectFailure for better test diagnosability. * Capture output logging in new tests * working through the review. Some test improvements. Changewave used. Comments. * addressing review comments * final review round, minor test update --------- Co-authored-by: Rainer Sigwald <raines@microsoft.com>
rainersigwald
added a commit
that referenced
this pull request
Nov 21, 2024
…rning properties (#11007) Backports #10942 to vs17.12 * add WarningsAsMessages, WarningsAsErrors, WarningsNotAsErrors and TreatWarningsAsErrors to the engine (e.g. variant without prefix). test those so that nothing breaks * Backport changwave 17.14 to 17.12 Normally we wouldn't have this changewave in this release, but because we want to have a consistent changewave for behavior changed after release, we're backporting it. * Bump version --------- Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Contributor
Author
|
I will revert this one temporarily to unblock msbuild-> sdk merging. However from the discussion we've had about this, we still want this change. Unfortunately it might require some additional ground work before we can push it through. |
This was referenced Nov 26, 2024
surayya-MS
added a commit
that referenced
this pull request
Nov 29, 2024
… and Tre…" (#11041) Reverts #10942 Due to the issue with sdk merge, I'm temporarily withdrawing this PR. dotnet/sdk#44977
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atWarningsAsErrors to the engine (e.g. variant without prefix). test those so that nothing breaks
Fixes #10877
Context
adding MSBuildWarnings... variants without prefix to the engine.
Changes Made
added WarningsAsMessages, WarningsAsErrors, WarningsNotAsErrors, TreatWarningsAsErrors to the engine parsing.
Testing
added a series of unit tests to ensure that these are consistent with the original behavior
further added unit tests to test the interaction & compatibility between the two.
Notes