Repository navigation
Run expert code review when a draft PR is marked ready for review - #14952
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ViktorHofer
approved these changes
Sep 7, 2026
AR-May
enabled auto-merge (squash)
September 7, 2026 09:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The trigger change is small, consistent with the PR description, and the regenerated lock file reflects it without introducing functional risk.
Pull request overview
Updates the expert-review workflow trigger so draft PRs that are later marked “Ready for review” will still get an automated expert review, aligning workflow behavior with common PR lifecycle usage.
Changes:
- Add
ready_for_reviewto thepull_request_targetevent types for the expert review workflow. - Regenerate the gh-aw compiled lock file to reflect the updated trigger configuration.
File summaries
| File | Description |
|---|---|
| .github/workflows/review-on-open.agent.md | Adds ready_for_review to the workflow trigger types so draft→ready transitions also invoke the agent. |
| .github/workflows/review-on-open.agent.lock.yml | Regenerated compiled workflow to include the updated trigger and updated metadata hash. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
ViktorHofer
approved these changes
Sep 7, 2026
This was referenced Sep 7, 2026
AR-May
added a commit
that referenced
this pull request
Sep 8, 2026
#14952 changed the `description` in `review-on-open.agent.md` but the committed lock file was not regenerated by `gh aw compile`. It kept the old description in three places and recorded a frontmatter hash that does not match the source. The activation job fails the hash check (`E009 CONFIG_HASH_MISMATCH`), so no expert review has run since Sep 7. Example: [run 34207754957](https://github.com/dotnet/msbuild/actions/runs/34207754957). Regenerated with `gh aw compile` (gh-aw v0.88.2). The new hash matches what the runtime computes. Generated output only; a full compile shows no other lock file is affected. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expert review workflow only triggers on
openedand skips draft pull requests. When a draft is later marked ready for review, nothing re-runs, so the pull request never gets reviewed.Adding
ready_for_reviewto the trigger types fixes this. The gh-aw issue that blocked it (#25436) was fixed in August, and the trigger is supported in v0.88.2, which this repository already uses.The lock file is regenerated.