Skip to content

Fix /warnaserror false positive overall success - #8953

Merged
JaynieBai merged 1 commit into
dotnet:mainfrom
rokonec:rokonec/fix-warnaserror-flaky-bug
Jun 27, 2023
Merged

Fix /warnaserror false positive overall success#8953
JaynieBai merged 1 commit into
dotnet:mainfrom
rokonec:rokonec/fix-warnaserror-flaky-bug

Conversation

@rokonec

@rokonec rokonec commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #8735, possibly #5689, #2845

Context

There were race condition when ProjectFinished log message has been processed after BuildResult event. Even though ProjectFinished log message event is always send before BuildResult event from Node, because ProjectFinished is asyncronously routed by LoggingService reversing order can and do often happen.

Changes Made

Updating _overallBuildSuccess in one place when submission is considered to be done and assumed its final state.

Testing

Can't local repro.

@rokonec
Check overall build success in one place
55cea2f 
where submission is considered to be done and assumed its final state
@rokonec
rokonec requested a review from AR-May June 26, 2023 09:35
AR-May
AR-May approved these changes Jun 26, 2023
View reviewed changes

@AR-May AR-May left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JanKrivanek
JanKrivanek approved these changes Jun 26, 2023
View reviewed changes

@JanKrivanek JanKrivanek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread src/Build/BackEnd/BuildManager/BuildManager.cs
@JaynieBai
JaynieBai merged commit c8c2aaa into dotnet:main Jun 27, 2023
This was referenced Jul 29, 2025
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Aug 6, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Aug 15, 2025
Closed
This was referenced Oct 15, 2025
Open
Closed
Closed
Closed
Closed
This was referenced Nov 13, 2025
Closed
Open
Open
Closed
Closed
Open
This was referenced Nov 26, 2025
Closed
Closed
Merged
This was referenced Dec 24, 2025
Merged
Merged
@dependabot dependabot Bot mentioned this pull request Mar 6, 2026
Merged
This was referenced Mar 27, 2026
Closed
Merged
@dependabot dependabot Bot mentioned this pull request May 15, 2026
Closed
@dependabot dependabot Bot mentioned this pull request May 18, 2026
Closed
@dependabot dependabot Bot mentioned this pull request May 27, 2026
Closed
This was referenced Jun 10, 2026
Closed
Closed
This was referenced Jun 24, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JanKrivanek JanKrivanek JanKrivanek approved these changes
@AR-May AR-May AR-May approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: /warnaserror false positive overall success

4 participants

@rokonec @JanKrivanek @AR-May @JaynieBai