Skip to content

When time increases by a digit, overwrite NodeStatus - #9563

Merged
AR-May merged 7 commits into
dotnet:vs17.9from
rainersigwald:tl-digit-muncher
Dec 21, 2023
Merged

AR-May merged 7 commits into
dotnet:vs17.9from
rainersigwald:tl-digit-muncher

Conversation

@rainersigwald

@rainersigwald rainersigwald commented Dec 19, 2023 •

Copy link
Copy Markdown
Member

Fixes #9562 by triggering a full-line redraw when the length of the duration string increases.

long-running.duration.pushes.left.mp4

@ghost

ghost commented Dec 19, 2023

Copy link
Copy Markdown

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@rainersigwald
rainersigwald requested a review from a team as a code owner December 19, 2023 20:26

@Forgind Forgind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread .vsts-dotnet-ci.yml Outdated
Comment thread src/MSBuild/TerminalLogger/SystemStopwatch.cs Outdated
Comment thread src/MSBuild/TerminalLogger/NodesFrame.cs Outdated
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
@AR-May
AR-May merged commit a1ad6b8 into dotnet:vs17.9 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants