Repository navigation
Revert "Load Microsoft.DotNet.MSBuildSdkResolver into default load context" - #9857
Merged
rainersigwald merged 2 commits intoMar 13, 2024
Merged
Conversation
…ntext (MSBuild.exe only) (dotnet#9439)" This reverts commit 6257b8e.
rokonec
approved these changes
Mar 13, 2024
JanKrivanek
approved these changes
Mar 13, 2024
JanKrivanek
left a comment
JanKrivanek
left a comment
Member
There was a problem hiding this comment.
Btw. what's the proper way of speeding the MSBuildSdkResolver?
Member
Author
I am still going to pursue this direction. I think the best thing to do is switch MSBuildSdkResolver to use System.Text.Json instead of Newtonsoft.Json. Then re-do this change, without the problematic assembly binding entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6257b8e (#9439)
Fixes AB#1974814 / AB#1993507
Context
The change added a binding entry for
Newtonsoft.Jsontomsbuild.exe.config. It turned out thatMicrosoft.DotNet.MSBuildSdkResolvermay not be installed (it is not an always-present component like MSBuild itself). The dangling entry makesNewtonsoft.Jsonfail to load into the MSBuild process. The assembly may be needed as a dependency of a task or another SDK resolver, for example.Changes Made
The change is reverted.
Testing
Verified that the failing scenarios work without the problematic entry in
MSBuild.exe.config.