Skip to content

Added retries and more checks for the ASP.NET Benchmarks#3469

Merged
cincuranet merged 5 commits into
dotnet:mainfrom
mrsharm:retry_for_aspnet
Nov 15, 2023
Merged

Added retries and more checks for the ASP.NET Benchmarks#3469
cincuranet merged 5 commits into
dotnet:mainfrom
mrsharm:retry_for_aspnet

Conversation

@mrsharm

@mrsharm mrsharm commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Added a corpnet connection check.
  2. Added a check for when the machines reboot - sleep until the reboot is complete.
  3. Added the ability to retry once after sleeping in case of hangs and unresponsiveness from the host.
  4. If there are failures in the run, those are automatically persisted as a new configuration file to make it easy to rerun after failures.

@mrsharm

mrsharm commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

@cincuranet, this PR is ready to go - could this be merged? Thanks in advance!

@cincuranet

cincuranet commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Done.

@cincuranet cincuranet merged commit 1f22991 into dotnet:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes
@cshung cshung Awaiting requested review from cshung
@mangod9 mangod9 Awaiting requested review from mangod9
+1 more reviewer
@markples markples markples left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrsharm @cincuranet @Maoni0 @markples